-
-
Notifications
You must be signed in to change notification settings - Fork 746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translations/: set Zzzz as SleepingSimpleString in all translations for unification #1866
Conversation
@ai I think we should stick with this choice. 😊 Other than that this can be merged. |
Ahaaa... I see, got it! Thanks for this input. Well, it means that unification makes even more sense then since it's not easy to put localized snoring sound from some other languages to 3 chars only.
Sure, no problem. I will update patch in a little bit. |
…slations for unification & update maxLen for SleepingSimpleString
Head branch was pushed to by a user without write access
Done. Plus, I updated |
@ia |
Ahaaaaaa...aye see! How interesting. Thanks for pointing this out, @discip. Sure, no problem! I will do a couple of tests & checks first but then I will provide updated patch to that. Sorry for my misunderstanding & lack of testing. Although the lesson which I should learn by now: the more trivial potential change looks - the bigger "undersea rocks" are somewhere out there! ;) |
What kind of change does this PR introduce?
Translation update.
What is the current behavior?
SleepingSimpleString
is different in many translation files and sometimes is above 4 chars.What is the new behavior (if this is a feature change)?
SleepingSimpleString
is set asZzzz
for all translations for unification.Other information:
Basically, this PR is inspired by this commit. My suggestion there was just to short "localized" "mimic" sound(s) to fit, but I guess more appropriate approach is to make it more unified. Let me know what you think.