Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translations/: set Zzzz as SleepingSimpleString in all translations for unification #1866

Merged
merged 3 commits into from
Jan 10, 2024

Conversation

ia
Copy link
Collaborator

@ia ia commented Jan 9, 2024

  • Please check if the PR fulfills these requirements
  • The changes have been tested locally
  • There are no breaking changes
  • What kind of change does this PR introduce?
    Translation update.

  • What is the current behavior?
    SleepingSimpleString is different in many translation files and sometimes is above 4 chars.

  • What is the new behavior (if this is a feature change)?
    SleepingSimpleString is set as Zzzz for all translations for unification.

  • Other information:
    Basically, this PR is inspired by this commit. My suggestion there was just to short "localized" "mimic" sound(s) to fit, but I guess more appropriate approach is to make it more unified. Let me know what you think.

@discip discip enabled auto-merge January 9, 2024 20:18
@discip
Copy link
Collaborator

discip commented Jan 9, 2024

@ai
As you should have noticed, in most languages ​​this expression was represented by Zzz rather than Zzzz.
This approach was chosen due to the fact that there should be a gap between the Zzz and the temperature reading, even if the value exceeds 99.

I think we should stick with this choice. 😊

Other than that this can be merged.

@ia
Copy link
Collaborator Author

ia commented Jan 10, 2024

@ai As you should have noticed, in most languages ​​this expression was represented by Zzz rather than Zzzz. This approach was chosen due to the fact that there should be a gap between the Zzz and the temperature reading, even if the value exceeds 99.

Ahaaa... I see, got it! Thanks for this input. Well, it means that unification makes even more sense then since it's not easy to put localized snoring sound from some other languages to 3 chars only.

I think we should stick with this choice. 😊

Sure, no problem. I will update patch in a little bit.

…slations for unification & update maxLen for SleepingSimpleString
auto-merge was automatically disabled January 10, 2024 02:12

Head branch was pushed to by a user without write access

@ia
Copy link
Collaborator Author

ia commented Jan 10, 2024

Done.

Plus, I updated maxLen for SleepingSimpleString in Translations/translations_definitions.json since it should be 3 to reflect the actual limit.

@discip discip enabled auto-merge January 10, 2024 06:18
@discip discip merged commit a1fb535 into Ralim:dev Jan 10, 2024
@discip
Copy link
Collaborator

discip commented Jan 10, 2024

@ia
Unfortunately I was not precise about what term exactly needs to be used.
Turns out it should read: Zzz please note the space after the last z.
Otherwise the temperature value will be shifted 1 char to the left remaining glued to the z. 🤦🏻
Meaning the total number of chars also remains 4.

@ia
Copy link
Collaborator Author

ia commented Jan 11, 2024

@ia Unfortunately I was not precise about what term exactly needs to be used. Turns out it should read: Zzz please note the space after the last z. Otherwise the temperature value will be shifted 1 char to the left remaining glued to the z. 🤦🏻 Meaning the total number of chars also remains 4.

Ahaaaaaa...aye see! How interesting. Thanks for pointing this out, @discip. Sure, no problem! I will do a couple of tests & checks first but then I will provide updated patch to that.

Sorry for my misunderstanding & lack of testing. Although the lesson which I should learn by now: the more trivial potential change looks - the bigger "undersea rocks" are somewhere out there! ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants