Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update translation_RU.json. Fixed a phrase that was too long causing … #1864

Merged
merged 1 commit into from
Jan 2, 2024

Conversation

NunkyJoe
Copy link
Contributor

@NunkyJoe NunkyJoe commented Jan 1, 2024

…temperature values to not fit on the sleep screen.

The sleep indication phrase in simple mode is too long "Хххррп". The temperature value does not fit on the screen. Replaced it with the original phrase "Zzzz", understandable in all languages.

  • Please check if the PR fulfills these requirements
  • [] The changes have been tested locally
  • [] There are no breaking changes
  • What kind of change does this PR introduce?
  • What is the current behavior?
  • What is the new behavior (if this is a feature change)?

  • Other information:

…temperature values to not fit on the sleep screen.

The sleep indication phrase in simple mode is too long "Хххррп". The temperature value does not fit on the screen. Replaced it with the original phrase "Zzzz", understandable in all languages.
@discip discip enabled auto-merge January 1, 2024 14:24
@discip discip disabled auto-merge January 1, 2024 14:24
@ia
Copy link
Collaborator

ia commented Jan 1, 2024

First, thanks to point out the issue: my bad was not to check all the strings for all modes & screens, sorry.

Second,

Replaced it with the original phrase "Zzzz", understandable in all languages.

the last part goes a bit more tricky the more I think about.

The point of translation (in general) - not only translation but adaptation. So I just thought it will be witty to put a string representing a sound of snoring as heard by Eastern Europeans usually, since that's what "z" for EN. Because for some other translations in IronOS (like for ES or SR_CYR) there are adaptations (of some sort) for this string already.

TL;DR:

  • if we do not only translation but "localization" as well, then the string should be just shorten like: Ххрп;
  • if we do "globalization" & unification, then the string should be indeed Zzzz, but at the same time this string Zzzz should be the same for every other language in Translations/ as well (the latter can be done later, when we figure out what to do here exactly).

Personally, I still would like to stick to the first option. But I really want to know what others have to say on that.

P.S. Happy New Year! 🎉

@discip discip enabled auto-merge January 2, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants