Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build.sh to pass shellcheck checks #1789

Merged
merged 2 commits into from
Aug 8, 2023
Merged

Update build.sh to pass shellcheck checks #1789

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
39ba9cf
source/build.sh: update according to shellcheck recommendations
ia Aug 7, 2023
c9dd834
Merge branch from dev to sync the commits
ia Aug 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 7 additions & 11 deletions source/build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#!/bin/bash
#!/usr/bin/env bash
set -e
TRANSLATION_DIR="../Translations"
#TRANSLATION_SCRIPT="make_translation.py"
Expand Down Expand Up @@ -91,14 +91,10 @@ while getopts "h:l:m:" option; do
usage
;;
l)
set -f
IFS=' '
largs=($OPTARG)
IFS=' ' read -r -a largs <<< "${OPTARG}"
;;
m)
set -f
IFS=' '
margs=($OPTARG)
IFS=' ' read -r -a margs <<< "${OPTARG}"
;;
*)
usage
Expand All @@ -124,7 +120,7 @@ if ((${#largs[@]})); then
done
echo ""
fi
if [ -z "$BUILD_LANGUAGES" ]; then
if [ -z "${BUILD_LANGUAGES[*]}" ]; then
echo " No custom languages selected."
echo " Building: [ALL LANGUAGES]"
BUILD_LANGUAGES+=("${AVAILABLE_LANGUAGES[@]}")
Expand All @@ -137,11 +133,11 @@ echo " ${AVAILABLE_MODELS[*]}"
echo -n "Requested models : "
if ((${#margs[@]})); then
for i in "${margs[@]}"; do

if [[ "$i" != "Pinecil" ]] && [[ "$i" != "Pinecilv2" ]]; then # Dirty. Need to adapt the Build process to use upper cases only
i=$(echo "${i}" | tr '[:lower:]' '[:upper:]')
fi

if isInArray "$i" "${AVAILABLE_MODELS[@]}"; then
echo -n "$i "
BUILD_MODELS+=("$i")
Expand All @@ -152,7 +148,7 @@ if ((${#margs[@]})); then
echo ""
fi

if [ -z "$BUILD_MODELS" ]; then
if [ -z "${BUILD_MODELS[*]}" ]; then
echo " No custom models selected."
echo " Building: [ALL MODELS]"
BUILD_MODELS+=("${AVAILABLE_MODELS[@]}")
Expand Down