Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build.sh to pass shellcheck checks #1789

Merged
merged 2 commits into from
Aug 8, 2023
Merged

Conversation

ia
Copy link
Collaborator

@ia ia commented Aug 8, 2023

  • Please check if the PR fulfills these requirements
  • The changes have been tested locally
  • There are no breaking changes
  • What kind of change does this PR introduce?
    Update build.sh according to shellcheck recommendations.

  • What is the current behavior?
    There are four warnings for build.sh currently.

  • What is the new behavior (if this is a feature change)?
    Update build.sh to remove shellcheck warnings.

  • Other information:
    I know that IFS without read should be ok but since shellcheck complains about checking arrays why wouldn't update those two as well.

@Ralim Ralim merged commit d5035bb into Ralim:dev Aug 8, 2023
@ia ia deleted the lint-build-sh branch August 13, 2023 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants