-
-
Notifications
You must be signed in to change notification settings - Fork 731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Calibrate CJC at next boot #1398
Conversation
Co-authored-by: Ben V. Brown <[email protected]>
@Ralim Makes the Do you have any clue on why only the |
Out of space, those extra bytes pushed you over the space left in flash |
btw: Do you have any idea what could help us to reclaim some space again? |
@Ralim |
Most likely future features will be masked off from the Miniware Irons (TS100/TS80/TS80P) at this point I want to look into compressing all languages (rather than just multi-lang packs) but not sure if that net gains any space or not. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me.
I'll hold off merging until I get a sec to test
I am good with that! 😃 |
@Ralim Hope you don't mind. |
@Ralim Thank you |
So creating a PR would not be an issue. 😊
|
I do not want to remove locking mode as it is not a large amount of space, not sure about the 80KB figure? Liekwise invert screen is liked by some so prefer not to take out the option, but might need to figure out about reducing its size cost? |
For the language option, I would need to figure out how the current system really works (I didnt write it) |
|
Tested on TS100 and works perfectly, so I think its good to gooooooo |
@Ralim |
language update (follow-up on #1398)
After reading this #1387 post, I had the idea to make CJC (Cold Junction Compensation) calibration as accurate as possible by executing it at boot.
This is an attempt to implement that to resolve #1387.
Tested this on both
TS80P
&Pinecil
.What has changed:
Calibrate temperature
is now calledCalibrate CJC at next boot
.Debug Menu
was partially rearranged and the entries were aligned, some of which were renamed to unify the appearance.Tip O
, which indicates the actual CJC offset.CHan
nowHan C
, is displayed directly in°C
to matchTip C
&Max C
.