Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only vbus mod check on pinecil #1224

Merged
merged 1 commit into from
Feb 12, 2022
Merged

Only vbus mod check on pinecil #1224

merged 1 commit into from
Feb 12, 2022

Conversation

Ralim
Copy link
Owner

@Ralim Ralim commented Feb 11, 2022

If a TS80P has it connected, other things blow up first at 20V
@discip
Copy link
Collaborator

discip commented Feb 11, 2022

Thank you! That worked! 😃👍

@Ralim
Copy link
Owner Author

Ralim commented Feb 11, 2022

Excellent.
If your pinecil has not been VBus modded, can you check it still correctly shows VBus being present?

@discip
Copy link
Collaborator

discip commented Feb 11, 2022

The Pinecil shows PWR PD W. VBus!
However if connected to PPS it restarts as well when entering the debug menu and reaching PWR! 😩

btw:
Is there any benefit of modding the VBus?

@Ralim
Copy link
Owner Author

Ralim commented Feb 11, 2022

yeah not surprised the probing interfears with PPS, to probe vbus we have to disconnect from the CC lines entirely for a bit.

Modding VBus means you can use a DC source that is 21-24V

@discip
Copy link
Collaborator

discip commented Feb 11, 2022

Thank you for the explanation! 👍

So not VBus mod for me! 😃

@discip
Copy link
Collaborator

discip commented Feb 11, 2022

Is this (restarting) fixable?

@Ralim
Copy link
Owner Author

Ralim commented Feb 12, 2022

Ish, Have to figure out good place to move the probe to.
This was just the easy place to do the probing, and to check that its done after negotiation

@discip
Copy link
Collaborator

discip commented Feb 12, 2022

So you do plan to do this? No pushing, just asking.

@Ralim
Copy link
Owner Author

Ralim commented Feb 12, 2022

Not for 2.17 release given I need to wrap that up soon.

@Ralim Ralim merged commit 6ecf630 into master Feb 12, 2022
@Ralim Ralim deleted the only-vbus-test-on-pinecil branch February 12, 2022 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants