Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pinecil mod detection #1215

Merged
merged 8 commits into from
Feb 6, 2022
Merged

Pinecil mod detection #1215

merged 8 commits into from
Feb 6, 2022

Conversation

Ralim
Copy link
Owner

@Ralim Ralim commented Feb 6, 2022

  • Please check if the PR fulfills these requirements
  • The changes have been tested locally
  • There are no breaking changes
  • What kind of change does this PR introduce?

Expanding the shown type in the debug menu to indicate if VBus is connected or not.
This allows user to check the VBus mod presence on a Pinecil for use over 21V

  • Other information:

Would love any pinecil testers (both modded and not).

It should show PD W. VBus if you have not done the mod, and PD No VBus if you have done the mod.

@Ralim Ralim added this to the 2.17 milestone Feb 6, 2022
@River-Mochi
Copy link
Contributor

Updated to firmware 2.16.FB29770 06-02-22

using USB-c to usb-C cable to PC. because that has enough power to view menu, selected minus long hold, then + to scroll through debug menu. I can see other settings like HW, time, move, rtip, ctip, CHan, Vin, ACC, PWR DC, Max, Hall
and nothing else,
It does not show me PD setting at all.

@thanos-the-tank-engine
Copy link

Flashed the Sciencil, registers PD No VBus, main pinecil registers PD W. VBus

@Ralim Ralim merged commit 5750afb into master Feb 6, 2022
@Ralim Ralim deleted the pinecil-mod-detect branch February 6, 2022 05:04
@River-Mochi
Copy link
Contributor

River-Mochi commented Feb 6, 2022

Connected to Pinepower USB-C 65W port.
menu correctly shows PWR PD No Vbus (because I cut the trace & modded pinecil to 24V)

might be better if it said sometihing more intuitive like
PWR DC24V Mod and PWR DC21V NoMod

C55780A6-BA02-4190-A836-EBCAAB72A964

@River-Mochi
Copy link
Contributor

River-Mochi commented Feb 6, 2022

Also tested by connecting old google pixel 2 cellphone (PD device) by usb-c cable to Pinecil and shows same PD No Vbus correct message as my pinecil's are 24V modded.

PD_phone_usb-c_to_Pinecil_2
Also tested connecting usb-C to anker usb-c 36W charger.
IMG_1474

All worked correctly and displayed same message indicating that my Vbus is not connected to PD and I have a successful cut of my trace.

@discip
Copy link
Collaborator

discip commented Feb 11, 2022

@Ralim
Good morning Sir,
I am having a question regarding this implementation.

  1. Should this work for all models?
  2. What exactly is VBus for? What does it do?

On my TS80P I am having an issue when browsing the debug menu and reaching PWR it states: PD No VBus and immediately restarts itself. 🤷‍♂️

Why is that?

@Ralim
Copy link
Owner Author

Ralim commented Feb 11, 2022

The mod is for Pinecil only, Miniware TS80P should show No VBus

VBus is a pin on the FUSB302 used for USB-PD negotiation that does not need to be connected and infact can cause issues if it is connected and you connect > 21V to the input on the Pinecil. So this is for detecting if VBus is actually wired up or not.

The iron should not restart itself though.

I cant reproduce the restart here? :/

@discip
Copy link
Collaborator

discip commented Feb 11, 2022

Could this be related to my power supply?

iron Firmware Version ACC Power Supply
TS80P https://github.com/Ralim/IronOS/actions/runs/1831832347 LIS2DH12 Anker Nano II 45W

@Ralim
Copy link
Owner Author

Ralim commented Feb 11, 2022

Shouldn't be related; does it restart any other times (not in the menu) ?

@discip
Copy link
Collaborator

discip commented Feb 11, 2022

Nope!

Or is it due to PPS?
Or the custom bootloader? 😵

@Ralim
Copy link
Owner Author

Ralim commented Feb 11, 2022

Shouldn't be any of those 😓
I cant reproduce it.
Could you check if its timing related? Like; if you enter the debug menu immediately does it crash, or is it if you leave it there for a while?
Does it crash on showing that text or when you next push a button?

@discip
Copy link
Collaborator

discip commented Feb 11, 2022

  1. It does crash almost immediately (~50ms).
  2. I do not need to press any button to let this happen.

I just tried it using different plugs:

Power Supply tech state
Anker Nano II 45W PPS resetting
UGREEN 65W GaN Charger fixed value not resetting

@Ralim
Copy link
Owner Author

Ralim commented Feb 11, 2022

Ahh wait, its probably because the TS80P does the software I2C (slow) and PPS needs the timings :/

@discip
Copy link
Collaborator

discip commented Feb 11, 2022

Since this is not needed for the TS80P anyway, I recommend limiting this exclusively to the Pinecil, instead of working this out. 😊

What do you think?

@Ralim
Copy link
Owner Author

Ralim commented Feb 11, 2022

Made pr to mask check.
I wish Miniware just had some brains in their design team :/ but yeah fair enough

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants