Skip to content

Commit

Permalink
cmake: Increase minimal required pylint version to 1.7.1
Browse files Browse the repository at this point in the history
Increase the minimal required version as older versions have a problem
with newer numpy versions.
Additionally, the new pylint version has a problem with symlinks
(pylint-dev/pylint#1470).
Therefore, run the pylint test directly on the source code and not on
the build folder.
  • Loading branch information
Stefan Wallner authored and suhlatwork committed Feb 8, 2018
1 parent 4bab229 commit e435352
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -297,7 +297,7 @@ set_package_properties(NumPy
# setup pylint (optional)
message(STATUS "")
message(STATUS ">>> Setting up pylint.")
find_package(PYLINT 1.5.5)
find_package(PYLINT 1.7.1)
set_package_properties(PYLINT
PROPERTIES
DESCRIPTION "code analysis for Python"
Expand Down
4 changes: 2 additions & 2 deletions pyInterface/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -162,12 +162,12 @@ if(PYLINT_FOUND)
# check 'pyRootPwa' module
add_test(
NAME pyLintPyRootPwa
COMMAND ${PYLINT_EXECUTABLE} --reports=n --rcfile=${CMAKE_CURRENT_SOURCE_DIR}/pylintrc pyRootPwa
COMMAND ${PYLINT_EXECUTABLE} --reports=n --rcfile=${CMAKE_CURRENT_SOURCE_DIR}/pylintrc module
)
set_property(
TEST pyLintPyRootPwa
APPEND
PROPERTY ENVIRONMENT "PYTHONPATH=${PYTHON_LIBRARY_OUTPUT_PATH}:$ENV{PYTHONPATH}"
PROPERTY ENVIRONMENT "PYTHONPATH=${CMAKE_CURRENT_SOURCE_DIR}:${PYTHON_LIBRARY_OUTPUT_PATH}:$ENV{PYTHONPATH}"
)

# check scripts
Expand Down

0 comments on commit e435352

Please sign in to comment.