Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify for getting solutions when setting alpha to 0 with A/B is nullptr #956

Merged
merged 6 commits into from
Jul 31, 2024
Merged

Modify for getting solutions when setting alpha to 0 with A/B is nullptr #956

merged 6 commits into from
Jul 31, 2024

Conversation

geotseng-amd
Copy link
Contributor

@geotseng-amd geotseng-amd commented Jul 26, 2024 •
edited
Loading

  1. Modify conditions in tensile_host.cpp and rocblaslt_mat_utils.hpp to enable the test case to get solutions when setting alpha to 0 with A/B as nullptr.
  2. Add a test case for getting solutions when setting alpha to 0 with A/B as nullptr
  3. Ticket: https://ontrack-internal.amd.com/browse/SWDEV-474250

TonyYHsieh
TonyYHsieh approved these changes Jul 26, 2024
View reviewed changes
Copy link
Contributor

@TonyYHsieh TonyYHsieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

TonyYHsieh
TonyYHsieh requested changes Jul 30, 2024
View reviewed changes
@geotseng-amd geotseng-amd requested a review from TonyYHsieh July 31, 2024 03:24
TonyYHsieh
TonyYHsieh approved these changes Jul 31, 2024
View reviewed changes
Copy link
Contributor

@TonyYHsieh TonyYHsieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jichangjichang
jichangjichang approved these changes Jul 31, 2024
View reviewed changes
Copy link
Collaborator

@jichangjichang jichangjichang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jichangjichang
Copy link
Collaborator

please use "squash and merge" and don't use "Rebase and merge"

@geotseng-amd
Copy link
Contributor Author

geotseng-amd commented Jul 31, 2024 •
edited
Loading

Local test results for PR#956 are all passed.

�[0;32m[----------] �[mGlobal test environment tear-down
�[0;32m[==========] �[m35004 tests from 13 test suites ran. (1879589 ms total)
�[0;32m[ PASSED ] �[m35004 tests.
hipBLASLt version: 800

@geotseng-amd geotseng-amd merged commit 7870ba7 into ROCm:develop Jul 31, 2024
1 of 2 checks passed
brianchooou pushed a commit to brianchooou/hipBLASLt that referenced this pull request Aug 8, 2024
@geotseng-amd @brianchooou
Modify for getting solutions when setting alpha to 0 with A/B is null…
e0c9ac7 
…ptr (ROCm#956)

* Modify for getting solutions when setting alpha to 0 with A/B is nullptr

* Add a test case for getting solutions when setting alpha to 0 with A/B is nullptr
@geotseng-amd geotseng-amd mentioned this pull request Nov 8, 2024
Merged
@geotseng-amd geotseng-amd mentioned this pull request Nov 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jichangjichang jichangjichang jichangjichang approved these changes

@TonyYHsieh TonyYHsieh TonyYHsieh approved these changes

@KKyang KKyang Awaiting requested review from KKyang KKyang is a code owner

@aazz44ss aazz44ss Awaiting requested review from aazz44ss

@vin-huang vin-huang Awaiting requested review from vin-huang vin-huang is a code owner

@imcarsonliao imcarsonliao Awaiting requested review from imcarsonliao imcarsonliao is a code owner

@hcman2 hcman2 Awaiting requested review from hcman2 hcman2 is a code owner

@Serge45 Serge45 Awaiting requested review from Serge45 Serge45 is a code owner

@Jinp800125 Jinp800125 Awaiting requested review from Jinp800125 Jinp800125 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@geotseng-amd @jichangjichang @TonyYHsieh