Modify to check if alpha is in host memory. #1356
Open
+53
−42
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick from #1326, #1335
Summary
In this PR, we modified the runtime verifications to check if Alpha is in host memory.
Due to a modification from PR#956, the CPU may try to access device memory through Alpha, which violates the BIOS restrictions.
Assigned Ticket: https://ontrack-internal.amd.com/browse/SWDEV-496511
Caused Ticket: https://ontrack-internal.amd.com/browse/SWDEV-482839
Caused PR: #956
Modifications
In hipBLASLt API
HIPBLASLT_MATMUL_DESC_POINTER_MODE has three modes as the following:
Only the HIPBLASLT_POINTER_MODE_HOST will ensure alpha is in host memory, so we modified validateMatmulArgs to check pointermode.
In hipBLASLtExt API
Since this ScaleAlphaVec is passed as a parameter through the API, we can simply push a nullptr as pointermode.