Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guard hip header for COMGR PCH #1265

Merged
merged 2 commits into from
Nov 8, 2021
Merged

Conversation

JehandadKhan
Copy link
Contributor

@JehandadKhan JehandadKhan commented Nov 7, 2021

Resolves the following:

In file included from /tmp/comgr-3768c9/input/batched_transpose.cpp:26:
In file included from /opt/rocm-4.3.1/include/hip/hip_runtime.h:49:
In file included from /usr/include/stdio.h:859:
/usr/include/x86_64-linux-gnu/bits/stdio.h:115:1: error: redefinition of 'getline'
getline (char **__lineptr, size_t *__n, FILE *__stream)
^
/usr/include/x86_64-linux-gnu/bits/stdio.h:115:1: note: previous definition is here
getline (char **__lineptr, size_t *__n, FILE *__stream)
^
In file included from /tmp/comgr-3768c9/input/batched_transpose.cpp:26:
In file included from /opt/rocm-4.3.1/include/hip/hip_runtime.h:49:
In file included from /usr/include/stdio.h:859:
/usr/include/x86_64-linux-gnu/bits/stdio.h:125:8: error: redefinition of 'feof_unlocked'
__NTH (feof_unlocked (FILE *__stream))
^
/usr/include/x86_64-linux-gnu/bits/stdio.h:125:2: note: previous definition is here
feof_unlocked (FILE *__stream) throw ()
^
fatal error: too many errors emitted, stopping now [-ferror-limit=]
20 errors generated when compiling for gfx90a.

atamazov
atamazov previously approved these changes Nov 7, 2021
Copy link
Contributor

@atamazov atamazov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

#include <hip/hip_runtime.h>
#include <hip/hip_fp16.h>
#endif

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra line

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@codecov

This comment has been minimized.

Copy link
Contributor

@carlushuang carlushuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@junliume junliume merged commit 4ca7d3f into develop Nov 8, 2021
@JehandadKhan JehandadKhan deleted the jd/batched_transpose_no_pch branch December 6, 2021 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants