Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TESTS] Add/fix tests for batched transpose #1266

Closed
atamazov opened this issue Nov 8, 2021 · 9 comments
Closed

[TESTS] Add/fix tests for batched transpose #1266

atamazov opened this issue Nov 8, 2021 · 9 comments

Comments

@atamazov
Copy link
Contributor

atamazov commented Nov 8, 2021

Let's add tests for batched transpose, so issues like #1265 won't show up anymore.

@carlushuang
Copy link
Contributor

@atamazov , the batched transpose I do added a test, but it is for nchw<->nhwc transform test/gpu_nchw_nhwc_transpose.cpp

nchw<->nhwc transform will use batched transpose internally, do you mean add another dedicated batched_tranpose test?

@atamazov
Copy link
Contributor Author

atamazov commented Nov 9, 2021

@carlushuang Any test that is able to catch the error from #1265 looks Ok to me.

@carlushuang
Copy link
Contributor

@atamazov OK, then I think we already have one :) test/gpu_nchw_nhwc_transpose.cpp

@atamazov
Copy link
Contributor Author

@carlushuang Good! But the remaining question is: why it didn't caught the #1265 problem when COMGR was enabled by default?

@carlushuang
Copy link
Contributor

carlushuang commented Nov 10, 2021

@atamazov that test need to compile the hip code: batched_transpose.cpp, and, actually I don't know the reason... that test will run by default on any arch, and #1247 also need to utilize this kernel ( compile this kernel), so I think we need this kernel compiled everywhere...

@atamazov
Copy link
Contributor Author

@carlushuang If test_gpu_nchw_nhwc_transpose is used, but compilation of batched_transpose.cpp didn't fail (-DMIOPEN_USE_COMGR=On, before #1265), then batched_transpose.cpp is not really used by the test. This must be fixed ASAP, I believe.

@atamazov atamazov changed the title [TESTS] Add tests for batched transpose [TESTS] Add/fix tests for batched transpose Nov 10, 2021
@carlushuang
Copy link
Contributor

@atamazov I did test locally, build MIOpen with -DMIOPEN_USE_COMGR=On and then try make check, and with out PR:#1265, it will fail in test_gpu_reference_kernel
image
So I think this test do can detect the comgr problem. But I don't know why previously CI didn't face with this problem...

@atamazov
Copy link
Contributor Author

@carlushuang This is different problem. You need to add LLVM_PATH for COMGR due to some SWDEV, see https://github.com/ROCmSoftwarePlatform/MIOpen/pull/1253/files#r747517006

@ppanchad-amd
Copy link

@carlushuang Is this fixed with latest ROCm 6.0.2 (HIP 6.0.32831)? If resolved, please close ticket. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants