-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TESTS] Add/fix tests for batched transpose #1266
Comments
@atamazov , the batched transpose I do added a test, but it is for nchw<->nhwc transform test/gpu_nchw_nhwc_transpose.cpp nchw<->nhwc transform will use batched transpose internally, do you mean add another dedicated batched_tranpose test? |
@carlushuang Any test that is able to catch the error from #1265 looks Ok to me. |
@atamazov OK, then I think we already have one :) test/gpu_nchw_nhwc_transpose.cpp |
@carlushuang Good! But the remaining question is: why it didn't caught the #1265 problem when COMGR was enabled by default? |
@carlushuang If |
@carlushuang This is different problem. You need to add LLVM_PATH for COMGR due to some SWDEV, see https://github.com/ROCmSoftwarePlatform/MIOpen/pull/1253/files#r747517006 |
@carlushuang Is this fixed with latest ROCm 6.0.2 (HIP 6.0.32831)? If resolved, please close ticket. Thanks! |
Let's add tests for batched transpose, so issues like #1265 won't show up anymore.
The text was updated successfully, but these errors were encountered: