Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tuning] rel-4.5 fdb update #1195

Merged
merged 2 commits into from
Oct 1, 2021

Conversation

cderb
Copy link
Contributor

@cderb cderb commented Sep 29, 2021

No description provided.

@junliume
Copy link
Contributor

@cderb and @JehandadKhan: do we attempt to merge into release/rocm-rel-4.5 directly or through release/rocm-rel-4.5-staging?

@JehandadKhan JehandadKhan changed the base branch from release/rocm-rel-4.5 to release/rocm-rel-4.5-staging September 29, 2021 17:32
@atamazov atamazov added this to the ROCm 4.5 milestone Sep 29, 2021
@junliume
Copy link
Contributor

@cderb and @JehandadKhan:
Failure on this issue, restarted to check if it is run to run:

FAILED: filesystem::recursive_directory_iterator increment error: No such file or directory

@atamazov
Copy link
Contributor

atamazov commented Sep 29, 2021

FAILED: filesystem::recursive_directory_iterator increment error: No such file or directory

Happened on ixt-sjc2-22 which is Navi21/36 during smoke testing with OCL backend. We do not supply fdb for it.

@junliume
Copy link
Contributor

@cderb @JehandadKhan : would this "fix" this issue: https://ontrack-internal.amd.com/browse/SWDEV-305355?

@codecov

This comment has been minimized.

@JehandadKhan
Copy link
Contributor

@cderb @JehandadKhan : would this "fix" this issue: https://ontrack-internal.amd.com/browse/SWDEV-305355?

Yes

Copy link
Contributor

@atamazov atamazov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, not good to go because #1196 has issues.

@junliume junliume dismissed atamazov’s stale review September 30, 2021 23:59

issue fixed: fdb entries no longer contain duplicate algorithms.

@junliume junliume merged commit 4503a5c into release/rocm-rel-4.5-staging Oct 1, 2021
@atamazov
Copy link
Contributor

atamazov commented Oct 1, 2021

Now in testing.

@atamazov
Copy link
Contributor

atamazov commented Oct 3, 2021

gfx906 perf testing results (ROCm 4.0)

🟢 Looks good. release/rocm-rel-4.5-staging, prior vs after merging cderb/fdb_tuning_4.5, tested with gfx906/60 & ROCm 4.0. Performance gain, based on sum of all times/directions:

    GPU time Wall time Aux Wall time
FP32/HIP Default find mode 1.14 1.08 1.45
  Immediate mode 1.13 1.11 1.50
FP16/HIP Default find mode 1.00 0.90 0.74
  Immediate mode 1.00 0.99 1.19
BF16/HIP Default find mode 1.00 0.95 1.09
  Immediate mode 1.00 1.00 1.13
FP32/OpenCL Default find mode 0.99 1.02 0.99
  Immediate mode 1.00 1.00 0.98

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants