-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tuning] rel-4.5 fdb update #1195
[Tuning] rel-4.5 fdb update #1195
Conversation
@cderb and @JehandadKhan: do we attempt to merge into release/rocm-rel-4.5 directly or through release/rocm-rel-4.5-staging? |
@cderb and @JehandadKhan:
|
Happened on ixt-sjc2-22 which is Navi21/36 during smoke testing with OCL backend. We do not supply fdb for it. |
@cderb @JehandadKhan : would this "fix" this issue: https://ontrack-internal.amd.com/browse/SWDEV-305355? |
This comment has been minimized.
This comment has been minimized.
Yes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately, not good to go because #1196 has issues.
issue fixed: fdb entries no longer contain duplicate algorithms.
Now in testing. |
gfx906 perf testing results (ROCm 4.0)🟢 Looks good. release/rocm-rel-4.5-staging, prior vs after merging cderb/fdb_tuning_4.5, tested with gfx906/60 & ROCm 4.0. Performance gain, based on sum of all times/directions:
|
No description provided.