[gfx90a] explicity disable asm solvers #1150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
shaojiewang
reviewed
Sep 12, 2021
junliume
reviewed
Sep 13, 2021
junliume
reviewed
Sep 13, 2021
junliume
reviewed
Sep 13, 2021
atamazov
suggested changes
Sep 13, 2021
There was a problem hiding this comment.
Please resolve:
- [gfx90a] explicity disable asm solvers #1150 (review)
- [gfx90a] explicity disable asm solvers #1150 (review)
- [gfx90a] explicity disable asm solvers #1150 (review)
Please also look at #1150 (review) and decide yourself what to do.
|
@shaojiewang Thanks for reviewing! |
junliume
pushed a commit
that referenced
this pull request
Sep 30, 2021
* explicity disable asm solvers for gfx90a * revert unnecessary gfx90a restrictions * fix ConvBinWinogradRxS formatting
This was referenced Sep 30, 2021
junliume
added a commit
that referenced
this pull request
Oct 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR disables asm solvers for gfx90a and marks as WORKAROUND for #1146.