Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle uppercase spelling of LEI in abcd #333

Merged
merged 1 commit into from
Dec 11, 2024
Merged

handle uppercase spelling of LEI in abcd #333

merged 1 commit into from
Dec 11, 2024

Conversation

jacobvjk
Copy link
Member

closes #328

this is one option to handle the inconsistent spelling in the raw abcd

Copy link

github-actions bot commented Dec 10, 2024

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-12-11 08:36 UTC

Copy link

codecov bot commented Dec 10, 2024

Codecov Report

Attention: Patch coverage is 53.33333% with 21 lines in your changes missing coverage. Please review.

Project coverage is 51.57%. Comparing base (619b9d9) to head (d4e1523).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
R/read_.R 53.33% 21 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #333      +/-   ##
==========================================
- Coverage   51.82%   51.57%   -0.25%     
==========================================
  Files          29       29              
  Lines        3178     3205      +27     
==========================================
+ Hits         1647     1653       +6     
- Misses       1531     1552      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jacobvjk jacobvjk marked this pull request as ready for review December 10, 2024 16:50
@jacobvjk jacobvjk requested review from cjyetman and jdhoffa December 10, 2024 16:51
@jacobvjk jacobvjk merged commit 8841fda into main Dec 11, 2024
11 checks passed
@jacobvjk jacobvjk deleted the colname-lei-LEI branch December 11, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ABCD has changed their column name from lei to LEI
2 participants