Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ABCD has changed their column name from lei to LEI #328

Closed
jdhoffa opened this issue Dec 10, 2024 · 1 comment · Fixed by #333
Closed

ABCD has changed their column name from lei to LEI #328

jdhoffa opened this issue Dec 10, 2024 · 1 comment · Fixed by #333
Assignees

Comments

@jdhoffa
Copy link
Member

jdhoffa commented Dec 10, 2024

We need to adapt our code accordingly

@jacobvjk
Copy link
Member

I think there are broadly two options here, if we want this to be backwards compatible.

One option would be to put the burden on the users, i.e. either let them define if the col name is spelled in uppercase or lowercase letters (probably in the config file, although that would be a pretty weird thing to configure) or explain in the cookbook that they may need to change the name in the raw data file (complicated and we probably do not want them to have to fiddle around in the raw data ideally).

The other option would be to implement some logic that tries to determine which format to look for. We could try to read the names of the sheet in first and determine which of spellings is used to then adjust the expected columns. I don't love this implementation, but it might be the best way forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants