Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dodge lines in emission intensity timeline plot #171

Merged
merged 3 commits into from
Dec 12, 2024
Merged

dodge lines in emission intensity timeline plot #171

merged 3 commits into from
Dec 12, 2024

Conversation

cjyetman
Copy link
Member

@cjyetman cjyetman commented Dec 12, 2024 •
edited
Loading

⚠️ maybe should dodge up instead of down so it doesn't overlap bottom x-axis tick marks?
⚠️ dodging dots on x-axis but not the line makes the dots seem disconnected from the line in some cases

@cjyetman cjyetman requested a review from MonikaFu as a code owner December 12, 2024 13:43
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 12, 2024 •
edited
Loading

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-12-12 14:53 UTC

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 12, 2024 •
edited
Loading

Docker build status

commit_time git_sha image
2024-12-12T14:25:32Z 73eb713 ghcr.io/rmi-pacta/pacta-dashboard-svelte:pr-171

@cjyetman cjyetman requested a review from jdhoffa December 12, 2024 13:48
jdhoffa
jdhoffa previously approved these changes Dec 12, 2024
View reviewed changes
jdhoffa
jdhoffa previously approved these changes Dec 12, 2024
View reviewed changes
Copy link
Member

@jdhoffa jdhoffa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

@cjyetman
Copy link
Member Author

@jdhoffa last change... dodge up and right (instead of up and left) to avoid overlapping y-axis ticks

@cjyetman cjyetman requested a review from jdhoffa December 12, 2024 14:27
@cjyetman cjyetman merged commit 9905962 into main Dec 12, 2024
11 checks passed
@cjyetman cjyetman deleted the dodge-lines-in-emission-intensity-timeline-plot branch December 12, 2024 14:52
@MonikaFu MonikaFu mentioned this pull request Jan 10, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdhoffa jdhoffa jdhoffa approved these changes

@MonikaFu MonikaFu Awaiting requested review from MonikaFu MonikaFu is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

missing portfolio emissions intensity
2 participants
@cjyetman @jdhoffa