-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
missing portfolio emissions intensity #142
Comments
The line (and dots) for portfolio values are there, it's just obscured because the scenario's line and dots are directly on top of it. @jdhoffa I could probably swap the order of them so the portfolio line is on top pretty easy, but then you won't see the scenario line. Something more sophisticated, like adding jitter or avoidance, would be much more complicated. Could also maybe make one of the lines and dots thicker so that you can still see it a bit even when it's underneath the other. |
@jdhoffa do you want me to look into this? |
Maybe! let me just talk to myself a bit first |
Putting portfolio on top seems to be just kicking the can (folks will ask why there is no scenario line). I think the Some resources here: @cjyetman could you give it a shot, and we see what it looks like? Doesn't need be perfect (might still decide not to go this way if it looks wonky). |
Another (slightly easier and maybe better looking option than jitter) option would be to use "dodging", where one of the lines is slightly bumped on the y-axis but always in the same direction so you don't end up with wavy lines. @jdhoffa can you try going to the test site, go to the sector-level tab, click go, switch to Aviation, then run the following code in the console and see if you like that result.. document.querySelector(".emission-intensity-plot path#Aviation_scen").style.transform = 'translateY(4px)';
let elements = document.querySelectorAll('.emission-intensity-plot .dot');
if (elements != undefined) {
for (let i = 0; i < elements.length; i++) {
if (i % 2) {
elements[i].style.transform = 'translateY(4px)';
}
}
} |
@jdhoffa and I agreed that dodging is the best way to go, using 8px y-axis dodge on the line and 8px x-axis and y-axis dodge on the dots |
No portfolio emissions intensity for Aviation/Listed Equity or Automotive/Listed Equity. Both have values of 100 micro tons of CO2 per [X] as Scenario target, with no change year to year.
The text was updated successfully, but these errors were encountered: