[RFC] ng_ipv6_addr: add (optional) string conversion functions #2546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miri64
added
Area: network
|
Hi, a quick word of warning: I'm currently on vacation with only a tablet (gasp!), so I can only read the code, but not try anything out... |
|
Well we have travis :D |
|
(otherwise feel free to reassign ;-)) |
| /** | ||
| * @brief Maximum length of an IPv6 address as string. | ||
| */ | ||
| /* take also encapsulated IPv4 address in account */ |
|
In the Interest of speeding things up I'll reassign... |
|
Reassigning to me to me to speed things up? You daredevil! |
miri64
force-pushed
the
ng_ipv6_addr/api/add_string_functions
branch
from
ebae2ed
to
f1c63ea
Compare
|
Rebased to current master. |
OlegHahm
added
the
CI: needs squashing
|
ACK |
miri64
force-pushed
the
ng_ipv6_addr/api/add_string_functions
branch
from
f1c63ea
to
b63d610
Compare
|
Rebased and fixed a minor doc error, travis was complaining about ;-) |
OlegHahm
removed
the
CI: needs squashing
|
All green |
OlegHahm
added a commit
that referenced
this pull request
Mar 13, 2015
…g_functions [RFC] ng_ipv6_addr: add (optional) string conversion functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the functions
ng_ipv6_addr_to_str()andng_ipv6_addr_from_str()(basicallyinet_pton6()andinet_ntop6()specialized for our types [I only made small rewrites to them]) to theng_ipv6_addrmodule. They only are included into the binary if they are used (since they are implemented in their own .c-files), and only are intended for debug output and the shell.The rational of including them to
ng_ipv6_addris that it can be used forDEBUG()output without including thenet_helpmodule. Additionally, I was able to simplify the implementation was a little bit due to the benefits ofng_ipv6_addr_t(as opposed to just usingchar *) andnetwork_uint32_t(for IPv4) addresses.I also removed one
snprintf()call (for just creating a hexadecimal number) and replaced it with manual formation. This makes this implementation much better suited for embedded devices.