Adding a script to check for line endings (valid UNIX ending)

[kushalsingh007]

-Created a bash script using grep to check for carriage return at line endings.
-Fix for issue #2281.

[kushalsingh007]

Yet again the build fail is due to Travis being flaky , kindly re-run the build again :)

[miri64]

Actually it fails because there are trailing whitespaces in your script. Please remove them ;)

[miri64]

(It's flaky when some random board fails. The static tests are quite stable)

Speaking of: could you add your script to them (add a call to your script to dist/tools/travis-scripts/build_and_test.sh). Also, I think it would be best if it only applies to new and changed files. Check out the other check scripts as for example dist/tools/whitespacecheck/check.sh or dist/tools/cppcheck/check.sh for how to do this.

[kushalsingh007]

Ok , I will have a look at it and make sure that the check applies only to new files :)

[kushalsingh007]

@authmillenon : I have added a new script which checks only for the newly added files and added a call to it in build_and_run.sh. However I do not have the permission to modify build_and_run.sh ( and that is why the static case fails ) . So have a look at it .

[miri64]

One call of your script with riot/master (the current master at RIOT-OS/RIOT) and --diff-filter=MA (only look at modified [M] and added [A] files) should suffice (source: http://git-scm.com/docs/git-diff).

[miri64]

However I do not have the permission to modify build_and_run.sh ( and that is why the static case fails ).

What do you mean? You obviously modified it (see my comment above). So how do you come to the impression you don't have any permission to do so? 😕

[kushalsingh007]

That's because it is the reason build failed
( see the travis result https://travis-ci.org/RIOT-OS/RIOT/jobs/53509103: permission denied error )

[miri64]

Ah... Your script is not executable. That's why Travis is saying the permissions were denied (because it has no permission to execute it). Git has an understanding of UNIX permission flags so you have to give your script execution permission:

chmod +x ./dist/tools/endingcheck/check.sh

[miri64]

(and than of course add this change to git ;)

git add ./dist/tools/endingcheck/check.sh
git commit

[kushalsingh007]

Done , the changes and the build

[miri64]

I would actually include all files, when I think about it, not just source code.

[kushalsingh007]

There are things like images which should be excluded from it.

[miri64]

Please squash only when the review is done, otherwise it can get a little bit confusing with bigger changes ;-)

[kushalsingh007]

Ok , I'll keep that in mind from next time. So , can I squash now to change the file regex ?

[miri64]

No, just mark the commits as squashable (I usually use a [SQUASH ME] tag in front of the commit description) and squash it, if you get the ACK ;-)

[miri64]

(I usually use a [SQUASH ME] tag in front of the commit description)

See #2546 for example

[jnohlgard]

Why is this duplicate line here?

[kushalsingh007]

@OlegHahm : Done squashing.