Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unittests: fix tests-pkt for non-32bit platforms #12456

Merged
merged 1 commit into from
Oct 15, 2019
Merged

unittests: fix tests-pkt for non-32bit platforms #12456

merged 1 commit into from
Oct 15, 2019

Conversation

miri64
Copy link
Member

@miri64 miri64 commented Oct 15, 2019

Contribution description

See notes on tests-pkt in #12447.

Testing procedure

make -C tests/unittests tests-pkt test

should work for non-32bit platforms.

Issues/PRs references

Alternative to #12447, depends on #12455

@miri64 miri64 added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Oct 15, 2019
@miri64 miri64 added this to the Release 2020.01 milestone Oct 15, 2019
@miri64 miri64 requested review from maribu and smlng October 15, 2019 07:56
@miri64 miri64 added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR State: waiting for other PR State: The PR requires another PR to be merged first and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Oct 15, 2019
@maribu
Copy link
Member

maribu commented Oct 15, 2019

Feel free to ping me once #12455 is merged (should be only waiting on Murdock) and this PR is rebased on master. (Otherwise I'll look into this PR again after lunch.)

@miri64 miri64 force-pushed the tests/fix/unittests-pkt-32-bit branch from e61881f to 18fc2c2 Compare October 15, 2019 08:40
@miri64
Copy link
Member Author

miri64 commented Oct 15, 2019

Rebased to current master.

@maribu maribu added Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines labels Oct 15, 2019
@maribu
Copy link
Member

maribu commented Oct 15, 2019

Works on Arduino-Mega2560

@maribu maribu added the Reviewed: 3-testing The PR was tested according to the maintainer guidelines label Oct 15, 2019
@miri64 miri64 removed the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Oct 15, 2019
maribu
maribu approved these changes Oct 15, 2019
View reviewed changes
Copy link
Member

@maribu maribu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@miri64 miri64 added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed State: waiting for other PR State: The PR requires another PR to be merged first labels Oct 15, 2019
@maribu maribu merged commit 68fcb73 into RIOT-OS:master Oct 15, 2019
@miri64 miri64 deleted the tests/fix/unittests-pkt-32-bit branch October 15, 2019 11:01
@aabadie aabadie mentioned this pull request Oct 16, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maribu maribu maribu approved these changes

@smlng smlng Awaiting requested review from smlng

Assignees
No one assigned
Labels
Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Projects
None yet
Milestone
Release 2020.01
Development

Successfully merging this pull request may close these issues.
2 participants
@miri64 @maribu