Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unittests: remove board blacklist, fix doc for MCU architectures #12455

Merged
merged 1 commit into from
Oct 15, 2019
Merged

unittests: remove board blacklist, fix doc for MCU architectures #12455

merged 1 commit into from
Oct 15, 2019

Conversation

miri64
Copy link
Member

@miri64 miri64 commented Oct 15, 2019

Contribution description

Moves unittests from BOARD_BLACKLIST to architecture FEATURES_*. Additionally, the doc is fixed from just "integer width" problem to document the specific problems with integer width (and other problems).

Testing procedure

tests/unittests should still pass the compile tests on CI.

Issues/PRs references

Alternative to #12447

@miri64 miri64 added Area: tests Area: tests and testing framework Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: run tests If set, CI server will run tests on hardware for the labeled PR labels Oct 15, 2019
@miri64 miri64 requested a review from smlng October 15, 2019 07:49
@miri64 miri64 added this to the Release 2020.01 milestone Oct 15, 2019
@miri64 miri64 mentioned this pull request Oct 15, 2019
Closed
@maribu maribu added Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines labels Oct 15, 2019
@maribu
Copy link
Member

maribu commented Oct 15, 2019

I have tested that (at least a randomly selected subset of the) blacklisting still works as expected.

@maribu maribu added the Reviewed: 3-testing The PR was tested according to the maintainer guidelines label Oct 15, 2019
maribu
maribu approved these changes Oct 15, 2019
View reviewed changes
Copy link
Member

@maribu maribu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@miri64 miri64 mentioned this pull request Oct 15, 2019
Merged
smlng
smlng approved these changes Oct 15, 2019
View reviewed changes
Copy link
Member

@smlng smlng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK2

@maribu maribu merged commit 63be700 into RIOT-OS:master Oct 15, 2019
@miri64 miri64 deleted the tests/cleanup/unittests-blacklist branch October 15, 2019 08:38
@aabadie aabadie mentioned this pull request Oct 16, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maribu maribu maribu approved these changes

@smlng smlng smlng approved these changes

Assignees
No one assigned
Labels
Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: run tests If set, CI server will run tests on hardware for the labeled PR Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Projects
None yet
Milestone
Release 2020.01
Development

Successfully merging this pull request may close these issues.
3 participants
@miri64 @maribu @smlng