Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci, Align test script to coreos/coreos-assembler #71

Merged
merged 3 commits into from
Nov 2, 2022
Merged

ci, Align test script to coreos/coreos-assembler #71

merged 3 commits into from
Nov 2, 2022

Conversation

RamLavi
Copy link
Collaborator

@RamLavi RamLavi commented Oct 30, 2022 •
edited
Loading

This PR fixes issues that caused the CI to brake. These changes are due to changed made on coreos-assembler repo:

  • Bumping our tests env to use go1.18
  • building kola with rchos-4.11 branch, that's currently the latest image.

Also fixing small typo in test script env var.

@RamLavi
ci, Bump go version to 1.18
b861c7b 
Current CI on coreos/coreos-assembler demands go version >=1.17.
Updating CI and scripts accordingly.

Signed-off-by: Ram Lavi <[email protected]>
@RamLavi RamLavi mentioned this pull request Oct 30, 2022
Merged
@RamLavi
Copy link
Collaborator Author

RamLavi commented Oct 30, 2022 •
edited
Loading

still failing on:

--- FAIL: rhcos.network.init-interfaces-test (1943.76s)
        harness.go:1501: Found systemd generator failure (/usr/lib/systemd/system-generators/coreos-diskful-generator) on machine 140279ad-f162-4a63-8025-0168338b13e5 console
+ expect_tests_to_succeed /tmp/coreos-assembler-bnXbcJ/tests_output
+ local test_output=/tmp/coreos-assembler-bnXbcJ/tests_output
--- FAIL: rhcos.network.multiple-nics (1044.07s)
        harness.go:1501: Found systemd generator failure (/usr/lib/systemd/system-generators/coreos-diskful-generator) on machine 063e6aac-9560-42fb-9085-c53[233](https://github.com/RHsyseng/rhcos-slb/actions/runs/3355409224/jobs/5559649489#step:5:234)2651cc console
FAIL, output in _kola_temp/qemu-unpriv-2022-10-30-1220-21519
++ grep FAIL: /tmp/coreos-assembler-bnXbcJ/tests_output
+ [[ -n --- FAIL: rhcos.network.init-interfaces-test (1943.76s)

From what I see this is something internal to core-os (see here). I've coreos-assembler about it on slack and currently waiting for a response..

@RamLavi
tests, Fix typo in coreos-assembler env var
5fea61f 
The repo fetched is of coreos-assembler and not rhcos-slb

Signed-off-by: Ram Lavi <[email protected]>
@RamLavi
tests: Change coreos-assembler repo branch
23343b4 
current latest image is pointing to rhcos-4.11 which is supported on
origin/rhcos-4.11 stable branch.
Fixing to align with currently published image

Signed-off-by: Ram Lavi <[email protected]>
@RamLavi RamLavi changed the title ci, Bump go version to 1.18 ci, Fix tests due to changes made on coreos-assembler repo Nov 2, 2022
@RamLavi RamLavi changed the title ci, Fix tests due to changes made on coreos-assembler repo ci, Align test script to coreos-assembler repo Nov 2, 2022
@RamLavi RamLavi changed the title ci, Align test script to coreos-assembler repo ci, Align test script to coreos/coreos-assembler Nov 2, 2022
@rabin-io
Copy link

rabin-io commented Nov 2, 2022

/LGTM

@RamLavi RamLavi merged commit 79a135d into RHsyseng:simplify-networking Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RamLavi @rabin-io