Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update init-interfaces.sh #70

Merged
merged 1 commit into from
Nov 2, 2022
Merged

Conversation

rabin-io
Copy link

@rabin-io rabin-io commented Oct 26, 2022

Do not abort if the 2nd connection fails,
In our GS environment we have one of bond interfaces disconnected, and the script will fail on this line, and abort, which failed to set the description on the connection.

@RamLavi
Copy link
Collaborator

RamLavi commented Oct 27, 2022

CI appears broken
Please check manually to see if it is originated by this PR change

@rabin-io
Copy link
Author

/retest

@RamLavi
Copy link
Collaborator

RamLavi commented Oct 30, 2022

@rabin-io I ran the ci locally on a clean simplify-networking branch:

make test

and the issue is still there.
We need to fix the CI before introducing this PR. I will update on that

@RamLavi
Copy link
Collaborator

RamLavi commented Oct 30, 2022

[UPDATE]
I issued a PR to upgrade the go version, let's see how it goes.

@phoracek
Copy link
Collaborator

phoracek commented Nov 2, 2022

IIUIC Rabin used this patched code on his real OpenShift BM environment and it worked there, correct @rabin-io ?

@RamLavi unless you have a hunch this patch may bring instability to the project, would you please consider merging it and resolving the CI issue in parallel?

@RamLavi
Copy link
Collaborator

RamLavi commented Nov 2, 2022

IIUIC Rabin used this patched code on his real OpenShift BM environment and it worked there, correct @rabin-io ?

@RamLavi unless you have a hunch this patch may bring instability to the project, would you please consider merging it and resolving the CI issue in parallel?

@phoracek #71 should fix it. I'm waiting to see the ci results.
@rabin-io if this change is urgent then we should split the effort as @phoracek suggests, is it?

Do not abort if the 2nd connection fails
Copy link
Collaborator

@RamLavi RamLavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@RamLavi RamLavi merged commit 7048cab into RHsyseng:simplify-networking Nov 2, 2022
@rabin-io rabin-io deleted the patch-2 branch November 13, 2022 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants