Resolve item desync bug #1029
Merged
Resolve item desync bug #1029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stilnat
requested changes
Feb 21, 2023
stilnat
approved these changes
Feb 21, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Attempt at resolving the item desync bug.
Seems to be caused by having the not-kinematic option set by Item.cs when placing an item. Normally this is not an issue, but it seems to act in a strange manner in combination with a NetworkTransform on the client. When placed sideways, the rigidbody on an object causes a rotation sync which creates the position drift.
Please test more before merging since I had some difficulties reliably reproducing the issue.
Fixes
#1017