Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fallback to old Store.bind signature on TypeError #2018

Merged
merged 1 commit into from
Jul 15, 2022

Commits on Jul 14, 2022

  1. Fallback to old Store.bind signature on TypeError

    If `Store.bind` raises a `TypeError`, and the string coversion of this
    TypeError contains `override`, then log a warning and call `Store.bind`
    without an override.
    
    This is done so that stores that do not accept `override` on
    `Store.bind` still work, but at the cost of still having the bug that
    was fixed by introducing the `override` parameter.
    
    Also added a private flag which can be used to disable the fix entirely
    and never use `override` when calling `Store.bind`.
    aucampia committed Jul 14, 2022
    Configuration menu
    Copy the full SHA
    65865ab View commit details
    Browse the repository at this point in the history