Fallback to old Store.bind signature on TypeError
#2018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aucampia
force-pushed
the
iwana-20220713T2226-bind_override
branch
from
937119f
to
ddb0561
Compare
If `Store.bind` raises a `TypeError`, and the string coversion of this TypeError contains `override`, then log a warning and call `Store.bind` without an override. This is done so that stores that do not accept `override` on `Store.bind` still work, but at the cost of still having the bug that was fixed by introducing the `override` parameter. Also added a private flag which can be used to disable the fix entirely and never use `override` when calling `Store.bind`.
aucampia
force-pushed
the
iwana-20220713T2226-bind_override
branch
from
ddb0561
to
65865ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
If
Store.bindraises aTypeError, and the string conversion of thisTypeError contains
override, then log a warning and callStore.bindwithout an override.
This is done so that stores that do not accept
overrideonStore.bindstill work, but at the cost of still having the bug thatwas fixed by introducing the
overrideparameter.Also added a private flag which can be used to disable the fix entirely
and never use
overridewhen callingStore.bind.overrideargument tordflib.store.Store.bindbreaks compatibility #1880Checklist
the same change.
so maintainers can fix minor issues and keep your PR up to date.