-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(qwik-city): Avoided unexpected caching for dynamic q-data #6797
Conversation
|
commit:
|
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fix looks great but we need a few changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🙌 Thanks!
…QwikDev#6797)" This reverts commit 7adb75a.
…c q-data (QwikDev#6797)"" This reverts commit 4a091aa.
…QwikDev#6797)" This reverts commit 7adb75a.
…QwikDev#6797)" This reverts commit 7adb75a.
…QwikDev#6797)" This reverts commit 7adb75a.
…QwikDev#6797)" This reverts commit 7adb75a.
…c q-data (QwikDev#6797)"" This reverts commit 99be307.
…QwikDev#6797)" This reverts commit 7adb75a.
What is it?
Description
Inside the
loadClientData
, thefetch()
had been called without the cache control options even if it is needed to avoid caching.So I added it if the
opts.clearCache
is set.Fixes #6789
Checklist:
pnpm change
and documented my changes