Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(qwik-city): Avoided unexpected caching for dynamic q-data #6797

Merged
merged 2 commits into from
Aug 16, 2024

Conversation

genki
Copy link
Contributor

@genki genki commented Aug 15, 2024

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests / types / typos
  • Infra

Description

Inside the loadClientData, the fetch() had been called without the cache control options even if it is needed to avoid caching.
So I added it if the opts.clearCache is set.

Fixes #6789

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have ran pnpm change and documented my changes
  • I have made corresponding changes to the Qwik docs
  • Added new tests to cover the fix / functionality

@genki genki requested review from a team as code owners August 15, 2024 18:22
Copy link

changeset-bot bot commented Aug 15, 2024

⚠️ No Changeset found

Latest commit: 088b6e9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

pkg-pr-new bot commented Aug 15, 2024

commit: 088b6e9

npm i https://pkg.pr.new/@builder.io/qwik@6797
npm i https://pkg.pr.new/@builder.io/qwik-city@6797
npm i https://pkg.pr.new/eslint-plugin-qwik@6797
npm i https://pkg.pr.new/create-qwik@6797

Open in Stackblitz

Copy link
Contributor

github-actions bot commented Aug 15, 2024

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview 088b6e9

Copy link
Member

@wmertens wmertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix looks great but we need a few changes

packages/qwik/src/optimizer/src/qwik-binding-map.ts Outdated Show resolved Hide resolved
packages/docs/src/routes/api/qwik/index.md Outdated Show resolved Hide resolved
packages/qwik-city/src/runtime/src/use-endpoint.ts Outdated Show resolved Hide resolved
Copy link
Member

@wmertens wmertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙌 Thanks!

@wmertens wmertens merged commit 7adb75a into QwikDev:main Aug 16, 2024
16 checks passed
maiieul added a commit to maiieul/qwik that referenced this pull request Aug 26, 2024
maiieul added a commit to maiieul/qwik that referenced this pull request Aug 27, 2024
maiieul added a commit to maiieul/qwik that referenced this pull request Aug 27, 2024
maiieul added a commit to maiieul/qwik that referenced this pull request Aug 27, 2024
maiieul added a commit to maiieul/qwik that referenced this pull request Aug 27, 2024
maiieul added a commit to maiieul/qwik that referenced this pull request Aug 27, 2024
maiieul added a commit to maiieul/qwik that referenced this pull request Aug 27, 2024
maiieul added a commit to maiieul/qwik that referenced this pull request Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🐞] SPA reload randomly fails to update the values loaded by the routeLoader$
2 participants