fix(qwik-city): Avoided unexpected caching for dynamic q-data (#6797)

QwikDev · Aug 16, 2024 · 7adb75a · 7adb75a
1 parent 6083989
commit 7adb75a
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 3 deletions.
diff --git a/packages/docs/src/repl/worker/app-bundle-client.ts b/packages/docs/src/repl/worker/app-bundle-client.ts
@@ -19,7 +19,7 @@ export const appBundleClient = async (
     srcInputs: getInputs(options),
     // Older versions don't support `segment`
     entryStrategy:
-      options.entryStrategy.type === 'segment' ? { type: 'hook' } : options.entryStrategy,
+      options.entryStrategy?.type === 'segment' ? { type: 'hook' } : options.entryStrategy,
     manifestOutput: (m) => {
       result.manifest = m;
     },

diff --git a/packages/qwik-city/src/runtime/src/use-endpoint.ts b/packages/qwik-city/src/runtime/src/use-endpoint.ts
@@ -28,7 +28,7 @@ export const loadClientData = async (
   let resolveFn: () => void | undefined;
 
   if (!qData) {
-    const fetchOptions = getFetchOptions(opts?.action);
+    const fetchOptions = getFetchOptions(opts?.action, opts?.clearCache);
     if (opts?.action) {
       opts.action.data = undefined;
     }
@@ -88,9 +88,21 @@ export const loadClientData = async (
   });
 };
 
-const getFetchOptions = (action: RouteActionValue | undefined): RequestInit | undefined => {
+const getFetchOptions = (
+  action: RouteActionValue | undefined,
+  noCache: boolean | undefined
+): RequestInit | undefined => {
   const actionData = action?.data;
   if (!actionData) {
+    if (noCache) {
+      return {
+        cache: 'no-cache',
+        headers: {
+          'Cache-Control': 'no-cache',
+          Pragma: 'no-cache',
+        },
+      };
+    }
     return undefined;
   }
   if (actionData instanceof FormData) {