Support substring matching in qube name text fields #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Making Pylint happy(er) |
marmarta
approved these changes
Jul 1, 2024
|
PipelineRetryFailed |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #171 +/- ##
==========================================
+ Coverage 77.99% 78.02% +0.02%
==========================================
Files 54 54
Lines 9664 9668 +4
==========================================
+ Hits 7537 7543 +6
+ Misses 2127 2125 -2 ☔ View full report in Codecov by Sentry. |
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2024070414-4.3&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2024062115-4.3&flavor=update
Failed tests13 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/103633#dependencies 4 fixed
Unstable tests
|
This was referenced Jul 3, 2024
|
Is this related to this commit? Or a policy error?
|
|
The other qrexec PR in the batch is broken. Now rerunning tests without it. |
marmarek
reviewed
Jul 4, 2024
| @@ -184,11 +184,22 @@ def apply_model( | |||
| completion.set_inline_selection(True) | |||
| completion.set_inline_completion(True) | |||
| completion.set_popup_completion(True) | |||
| completion.set_popup_single_match(False) | |||
| completion.set_popup_single_match(True) | |||
There was a problem hiding this comment.
Can you explain this change? It means you can't accept a single match (after typing it in) with a single click anymore, you need two clicks. OpenQA found this out, but TBH I'm not sure if that's a common case.
There was a problem hiding this comment.
Can you explain this change?
That is something I found only after using the patch for a while. The default logic (matching from the start) does not require to show the popup for a single match if user has entered the entire string.
In our case, if user wants to search for disp1234 and user has currenty disp1234, dips5678 and disp90 running at the moment and user types 1, there will be no popup to select disp1234 from it if popup_single_match is set to False.
There was a problem hiding this comment.
p.s. Actually the GTK default matching algorithm is also insufficient if a popup is not shown. As it is case in-senstivie and Qube names are case-sensitive.
marmarek
approved these changes
Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: QubesOS/qubes-issues#8583