tests: update expeted error codes of qubes-vm-update #604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When refreshing metadata fails, it's supposed to exit with code 23. Related to QubesOS/qubes-core-admin-linux#160
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #604 +/- ##
=======================================
Coverage 69.35% 69.35%
=======================================
Files 58 58
Lines 11919 11919
=======================================
Hits 8266 8266
Misses 3653 3653
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2024070414-4.3&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2024062115-4.3&flavor=update
Failed tests13 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/103633#dependencies 4 fixed
Unstable tests
|
This was referenced Jul 3, 2024
Merged
Previously the expected_ret_codes applied to both qubes-vm-update and later check if a package was updated (`rpm -q|grep ...` etc). With unified qubes-vm-update exit codes, this approach is too broad as qubes-vm-update is now expected to exit with very specific error, not just "any error" - and this doesn't match grep's exit code anymore. Fix this by adding another parameter for expected grep result (whether updated package is expected or not).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When refreshing metadata fails, it's supposed to exit with code 23.
Related to QubesOS/qubes-core-admin-linux#160