Refactor: Coinbase authentication #492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor Authentication Name for Coinbase: The naming convention for the authentication method has been updated to improve clarity and consistency across the codebase.
Fix Escape Character Bug: A bug was addressed where the cdp privateKey containing escape characters (e.g., \n) would incorrectly be transformed into double backslashes (\n). This fix ensures that escape characters are properly handled and preserved.
Related PRs
Motivation and Context
Refactor Authentication Name: The refactor aims to enhance the readability and maintainability of the authentication code for Coinbase, aligning with naming conventions and making the code easier to understand and manage.
Fix Escape Character Bug: The bug fix resolves an issue that could lead to incorrect handling of private keys with escape characters. This improvement ensures that the
cdp privateKeyis processed accurately, preventing potential authentication issues.