Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: new Authentication process #23

Merged
merged 17 commits into from
Aug 21, 2024

Conversation

Romazes
Copy link
Contributor

@Romazes Romazes commented Aug 19, 2024

Description

This pull request implements a new authentication mechanism for the Advanced Trade WebSocket API using Coinbase's CDP API keys. The CDP API keys are utilized to generate a JSON Web Token (JWT), which is then set as a Bearer token in the Authorization header for making authenticated requests. This approach replaces the deprecated legacy authentication method that used api_key and api_key_secret, which is no longer supported by Coinbase.

Related Issue

Closes #22

Motivation and Context

The legacy authentication method using api_key and api_key_secret has been deprecated and is no longer supported by Coinbase for the Advanced Trade WebSocket API. To ensure continued access and functionality, it is essential to transition to the new JWT-based authentication mechanism provided by Coinbase's CDP API keys. This update aligns the project with the latest security standards and ensures compatibility with Coinbase's current API requirements.

Requires Documentation Change

N/A

How Has This Been Tested?

  • Refactored Existing Tests: The existing test cases were refactored to accommodate the new JWT-based authentication mechanism.
  • Test Execution: All refactored tests were executed to ensure that the new implementation works as expected and maintains compatibility with the previous test scenarios.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which improves implementation)
  • Performance (non-breaking change which improves performance. Please add associated performance test and results)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Non-functional change (xml comments/documentation/etc)

Checklist:

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My branch follows the naming convention bug-<issue#>-<description> or feature-<issue#>-<description>

@Romazes Romazes added the bug Something isn't working label Aug 19, 2024
@Romazes Romazes self-assigned this Aug 19, 2024
Copy link
Member

@Martin-Molinero Martin-Molinero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, shared minor requests through slack 👍

@Martin-Molinero Martin-Molinero merged commit 7c2b562 into QuantConnect:master Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review Authetication Method
2 participants