generated from QuantConnect/Lean.Brokerages.Template
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: new Authentication process #23
Merged
Martin-Molinero
merged 17 commits into
QuantConnect:master
from
Romazes:feature-new-auth-method
Aug 21, 2024
Merged
Feature: new Authentication process #23
Martin-Molinero
merged 17 commits into
QuantConnect:master
from
Romazes:feature-new-auth-method
Aug 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test:feat: validate JWT token
Martin-Molinero
approved these changes
Aug 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, shared minor requests through slack 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request implements a new authentication mechanism for the Advanced Trade WebSocket API using Coinbase's CDP API keys. The CDP API keys are utilized to generate a JSON Web Token (JWT), which is then set as a Bearer token in the Authorization header for making authenticated requests. This approach replaces the deprecated legacy authentication method that used
api_key
andapi_key_secret
, which is no longer supported by Coinbase.Related Issue
Closes #22
Motivation and Context
The legacy authentication method using
api_key
andapi_key_secret
has been deprecated and is no longer supported by Coinbase for the Advanced Trade WebSocket API. To ensure continued access and functionality, it is essential to transition to the new JWT-based authentication mechanism provided by Coinbase's CDP API keys. This update aligns the project with the latest security standards and ensures compatibility with Coinbase's current API requirements.Requires Documentation Change
N/A
How Has This Been Tested?
Types of changes
Checklist:
bug-<issue#>-<description>
orfeature-<issue#>-<description>