Fix Furo styling for API pages with methods on class page (Cherry-pick of #458) #478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're planning to switch some Qiskit projects to stop having dedicated HTML pages per method, mostly due to performance concerns. Closes Qiskit#466. Methods were using `inline-block` rather than `block` when on the classes page, which resulted in a bug when highlighting over the method to show the `#` anchor tag:  Instead, we now turn off floating of the `[source]` label because it causes issues on long code signatures:  After:  Even though the `[source]` floating to the right is more "elegant", we have too many long signatures in Qiskit to be worth it. It's safer to turn off the float. This also improves the information hierarchy so that page feels less crowded. Relates to Qiskit#459: * Use a border-width of 2px for top-level code objects, but otherwise 1 * Increases the font sizes so headings look bigger.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're planning to switch some Qiskit projects to stop having dedicated HTML pages per method, mostly due to performance concerns.
Closes #466. Methods were using
inline-blockrather thanblockwhen on the classes page, which resulted in a bug when highlighting over the method to show the#anchor tag:Instead, we now turn off floating of the
[source]label because it causes issues on long code signatures:After:
Even though the
[source]floating to the right is more "elegant", we have too many long signatures in Qiskit to be worth it. It's safer to turn off the float.This also improves the information hierarchy so that page feels less crowded. Relates to
#459: