Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add falqon algorithm to qiskit-terra #9624

Closed
wants to merge 1 commit into from
Closed

Conversation

tpecyna
Copy link

@tpecyna tpecyna commented Feb 20, 2023

Summary

To add the Feedback-based quantum optimization (falqon) algorithm (arxiv).

Details and comments

I had to close the previous issue #8751 for some reason. I've implemented into the algorithm the Estimator primitive and the MinimumEigensolver interface. Now I have the following questions:

  1. Falqon algorithm works in a simple iteration loop, in which it measures an ansatz with some commutator operator, then it multiplies the expval by $-1$ and finally uses the result as one of the parameters of the next circuit of length $i+1$. For longer circuits it takes more time to run them so there is a high probability that users will always want to track the intermediate results:
    a) should this main loop remain to be implemented inside the falqon class and handling of the intermediate results be left to a callback function implemented by users,
    b) or should the simple loop be left for implementation by the users, and the class would then only contain building ansatz and making measurements?
  2. In case of QAOA we pass Sampler, and then DiagonalEstimator is created, so we can have both the eigenvalue and the eigenstate. In Falqon we can't use the DiagonalEstimator because the commutator Hamiltonian is not diagonal. How to manage that? Should the class constructor ask for both Sampler and Estimator?

Thanks

@qiskit-bot qiskit-bot added the Community PR PRs from contributors that are not 'members' of the Qiskit repo label Feb 20, 2023
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the the following people are requested to review this:

@tpecyna tpecyna changed the title implement MinimumEigensolver interface Implement the Falqon Algorithm Feb 20, 2023
@tpecyna tpecyna changed the title Implement the Falqon Algorithm Add falqon algorithm to qiskit-terra Feb 20, 2023
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@woodsp-ibm woodsp-ibm added the mod: algorithms Related to the Algorithms module label Mar 3, 2023
@woodsp-ibm
Copy link
Member

Thank you for your interest in contributing to Qiskit. It has however been decided that the algorithms are to be moved out of Qiskit (see #10406) and the plan is a new community repository that will contain these going forwards. As such I am going to close this PR as it stands.

If you still have interest in pursuing this then might I suggest a community project in the ecosystem for this. See https://qiskit.org/ecosystem/ and follow/click the "Join the ecosystem" for more information on what that would entail.

@woodsp-ibm woodsp-ibm closed this Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community PR PRs from contributors that are not 'members' of the Qiskit repo mod: algorithms Related to the Algorithms module
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants