Add falqon algorithm to qiskit-terra #9624
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
To add the Feedback-based quantum optimization (falqon) algorithm (arxiv).
Details and comments
I had to close the previous issue #8751 for some reason. I've implemented into the algorithm the
Estimator
primitive and theMinimumEigensolver
interface. Now I have the following questions:a) should this main loop remain to be implemented inside the falqon class and handling of the intermediate results be left to a callback function implemented by users,
b) or should the simple loop be left for implementation by the users, and the class would then only contain building ansatz and making measurements?
Sampler
, and thenDiagonalEstimator
is created, so we can have both the eigenvalue and the eigenstate. In Falqon we can't use theDiagonalEstimator
because the commutator Hamiltonian is not diagonal. How to manage that? Should the class constructor ask for bothSampler
andEstimator
?Thanks