Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add falqon algorithm to qiskit-terra #8751

Closed
wants to merge 2 commits into from
Closed

Add falqon algorithm to qiskit-terra #8751

wants to merge 2 commits into from

Conversation

tpecyna
Copy link

@tpecyna tpecyna commented Sep 14, 2022

Summary

To add the Feedback-based quantum optimization (falqon) algorithm (arxiv.)

Details and comments

I lack the falqon algorithm in qiskit. I've written my own little version based on other implementations and I would like to adjust it so I can contribute do qiskit-terra. I am asking for suggestions on the next steps to be taken.

@qiskit-bot qiskit-bot added the Community PR PRs from contributors that are not 'members' of the Qiskit repo label Sep 14, 2022
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the the following people are requested to review this:

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@woodsp-ibm
Copy link
Member

Hi. At present the existing algorithms in Qiskit Terra are being refactored to use the primitives (samplers and estimators) that have been introduced to Qiskit (existing algorithms are all being marked pending deprecation and will later be deprecated and removed). For instance VQE, QAOA are refactored here #8702 and #8669 and you might like to take a look to see if/how this algorithm you have implemented can be done using such primitives. Also as a minimum eigen solver the algorithm should implement the MinimumEigensolver interface to allow any upper level applications to use the algorithm in a standard way via that interface. You can see this in the referenced PRs where VQE etc implement this interface and pass back a given result type, although they can extend the result class and add algorithm result specifics.

@woodsp-ibm woodsp-ibm added the mod: algorithms Related to the Algorithms module label Sep 14, 2022
@tpecyna tpecyna closed this Nov 24, 2022
@tpecyna tpecyna deleted the falqon-algorithm branch November 24, 2022 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community PR PRs from contributors that are not 'members' of the Qiskit repo mod: algorithms Related to the Algorithms module
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants