Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explanatory reference to PiecewiseChebychev #8393

Merged
merged 5 commits into from
Jul 26, 2022
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions qiskit/algorithms/linear_solvers/hhl.py
Original file line number Diff line number Diff line change
Expand Up @@ -87,12 +87,12 @@ class HHL(LinearSolver):
References:

[1]: Harrow, A. W., Hassidim, A., Lloyd, S. (2009).
Quantum algorithm for linear systems of equations.
`Phys. Rev. Lett. 103, 15 (2009), 1–15. <https://doi.org/10.1103/PhysRevLett.103.150502>`_
Quantum algorithm for linear systems of equations.
`Phys. Rev. Lett. 103, 15 (2009), 1–15. <https://doi.org/10.1103/PhysRevLett.103.150502>`_

[2]: Carrera Vazquez, A., Hiptmair, R., & Woerner, S. (2020).
Enhancing the Quantum Linear Systems Algorithm using Richardson Extrapolation.
`arXiv:2009.04484 <http://arxiv.org/abs/2009.04484>`_
[2]: Vazquez, A. C., Hiptmair, H., & Woerner, S. (2022).
Cryoris marked this conversation as resolved.
Show resolved Hide resolved
Enhancing the Quantum Linear Systems Algorithm Using Richardson Extrapolation.
`ACM Transactions on Quantum Computing 3, 1, Article 2 https://doi.org/10.1145/3490631`_
Cryoris marked this conversation as resolved.
Show resolved Hide resolved

"""

Expand Down
6 changes: 5 additions & 1 deletion qiskit/circuit/library/arithmetic/piecewise_chebyshev.py
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,8 @@ class PiecewiseChebyshev(BlueprintCircuit):
polynomial Chebyshev approximation on :math:`n` qubits to :math:`f(x)` on the given intervals.
All the polynomials in the approximation are of degree :math:`d`.

The values of the parameters are calculated according to [1].
The values of the parameters are calculated according to [1] and see [2] for a more
detailed explanation of the circuit construction and how it acts on the qubits.

Examples:

Expand All @@ -51,6 +52,9 @@ class PiecewiseChebyshev(BlueprintCircuit):
[1]: Haener, T., Roetteler, M., & Svore, K. M. (2018).
Optimizing Quantum Circuits for Arithmetic.
`arXiv:1805.12445 <http://arxiv.org/abs/1805.12445>`_
[2]: Vazquez, A. C., Hiptmair, H., & Woerner, S. (2022).
Cryoris marked this conversation as resolved.
Show resolved Hide resolved
Enhancing the Quantum Linear Systems Algorithm Using Richardson Extrapolation.
`ACM Transactions on Quantum Computing 3, 1, Article 2 https://doi.org/10.1145/3490631`_
Cryoris marked this conversation as resolved.
Show resolved Hide resolved
"""

def __init__(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -81,9 +81,9 @@ class PiecewisePolynomialPauliRotations(FunctionalPauliRotations):
Optimizing Quantum Circuits for Arithmetic.
`arXiv:1805.12445 <http://arxiv.org/abs/1805.12445>`_

[2]: Carrera Vazquez, A., Hiptmair, R., & Woerner, S. (2020).
[2]: Carrera Vazquez, A., Hiptmair, R., & Woerner, S. (2022).
Enhancing the Quantum Linear Systems Algorithm using Richardson Extrapolation.
`arXiv:2009.04484 <http://arxiv.org/abs/2009.04484>`_
`ACM Transactions on Quantum Computing 3, 1, Article 2 https://doi.org/10.1145/3490631`_
Cryoris marked this conversation as resolved.
Show resolved Hide resolved
"""

def __init__(
Expand Down