-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add explanatory reference to PiecewiseChebychev
#8393
Conversation
and update other locations with published version
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, just that Carrera is my surname :)
Pull Request Test Coverage Report for Build 2738661864
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The docs builds are failing because of a syntax error with the external links
qiskit/circuit/library/arithmetic/piecewise_polynomial_pauli_rotations.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Matthew Treinish <[email protected]>
* Add explanatort reference to ``PiecewiseChebychev`` and update other locations with published version * fix name * Fix links Co-authored-by: Matthew Treinish <[email protected]> Co-authored-by: Matthew Treinish <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit 35bb826)
* Add explanatort reference to ``PiecewiseChebychev`` and update other locations with published version * fix name * Fix links Co-authored-by: Matthew Treinish <[email protected]> Co-authored-by: Matthew Treinish <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit 35bb826) Co-authored-by: Julien Gacon <[email protected]>
* Add explanatort reference to ``PiecewiseChebychev`` and update other locations with published version * fix name * Fix links Co-authored-by: Matthew Treinish <[email protected]> Co-authored-by: Matthew Treinish <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
* Add explanatort reference to ``PiecewiseChebychev`` and update other locations with published version * fix name * Fix links Co-authored-by: Matthew Treinish <[email protected]> Co-authored-by: Matthew Treinish <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
and update other locations with published version
Summary
Add a missing reference to
PiecewiseChebychev
that explains where the circuit is coming from. Also update locations of with the arXiv version with the published version of the paper.Details and comments