Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explanatory reference to PiecewiseChebychev #8393

Merged
merged 5 commits into from
Jul 26, 2022

Conversation

Cryoris
Copy link
Contributor

@Cryoris Cryoris commented Jul 25, 2022

and update other locations with published version

Summary

Add a missing reference to PiecewiseChebychev that explains where the circuit is coming from. Also update locations of with the arXiv version with the published version of the paper.

Details and comments

and update other locations with published version
@Cryoris Cryoris added Changelog: None Do not include in changelog documentation labels Jul 25, 2022
@Cryoris Cryoris requested review from a team, manoelmarques and woodsp-ibm as code owners July 25, 2022 11:16
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the the following people are requested to review this:

Copy link
Contributor

@anedumla anedumla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just that Carrera is my surname :)

qiskit/algorithms/linear_solvers/hhl.py Outdated Show resolved Hide resolved
qiskit/circuit/library/arithmetic/piecewise_chebyshev.py Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Jul 25, 2022

Pull Request Test Coverage Report for Build 2738661864

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.002%) to 83.988%

Files with Coverage Reduction New Missed Lines %
qiskit/extensions/quantum_initializer/squ.py 2 80.9%
Totals Coverage Status
Change from base Build 2733327133: 0.002%
Covered Lines: 55883
Relevant Lines: 66537

💛 - Coveralls

@javabster javabster modified the milestone: 0.22 Jul 25, 2022
@mtreinish mtreinish added this to the 0.21.1 milestone Jul 25, 2022
@mtreinish mtreinish added the stable backport potential The bug might be minimal and/or import enough to be port to stable label Jul 25, 2022
Copy link
Member

@mtreinish mtreinish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The docs builds are failing because of a syntax error with the external links

qiskit/algorithms/linear_solvers/hhl.py Outdated Show resolved Hide resolved
qiskit/circuit/library/arithmetic/piecewise_chebyshev.py Outdated Show resolved Hide resolved
Co-authored-by: Matthew Treinish <[email protected]>
@mergify mergify bot merged commit 35bb826 into Qiskit:main Jul 26, 2022
mergify bot pushed a commit that referenced this pull request Jul 26, 2022
* Add explanatort reference to ``PiecewiseChebychev``

and update other locations with published version

* fix name

* Fix links

Co-authored-by: Matthew Treinish <[email protected]>

Co-authored-by: Matthew Treinish <[email protected]>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
(cherry picked from commit 35bb826)
mergify bot added a commit that referenced this pull request Jul 26, 2022
* Add explanatort reference to ``PiecewiseChebychev``

and update other locations with published version

* fix name

* Fix links

Co-authored-by: Matthew Treinish <[email protected]>

Co-authored-by: Matthew Treinish <[email protected]>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
(cherry picked from commit 35bb826)

Co-authored-by: Julien Gacon <[email protected]>
ElePT pushed a commit to ElePT/qiskit that referenced this pull request Jun 27, 2023
* Add explanatort reference to ``PiecewiseChebychev``

and update other locations with published version

* fix name

* Fix links

Co-authored-by: Matthew Treinish <[email protected]>

Co-authored-by: Matthew Treinish <[email protected]>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
ElePT pushed a commit to ElePT/qiskit-algorithms-test that referenced this pull request Jul 17, 2023
* Add explanatort reference to ``PiecewiseChebychev``

and update other locations with published version

* fix name

* Fix links

Co-authored-by: Matthew Treinish <[email protected]>

Co-authored-by: Matthew Treinish <[email protected]>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: None Do not include in changelog stable backport potential The bug might be minimal and/or import enough to be port to stable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants