Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add transpiler directory for pulse transforms #6724

Closed
wants to merge 10 commits into from
Closed

Add transpiler directory for pulse transforms #6724

wants to merge 10 commits into from

Conversation

vkumar19
Copy link

Summary

Moved files from scheduling folder to the transformation folder

Details and comments

Issue #6079

@vkumar19 vkumar19 requested a review from a team as a code owner July 12, 2021 21:02
@kdk kdk changed the title adding edits to resolve issue 6079 Add transpiler directory for pulse transforms Jul 13, 2021
kdk
kdk reviewed Jul 13, 2021
View reviewed changes
Copy link
Member

@kdk kdk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking this on @vkumar19 . Two quick comments. Instead of copying the files, can you use git mv so that the commit history is preserved? Also, can you deprecate the old import locations? An example of how to do this can be found for the CheckCXDirection pass in #5609 .

@vkumar19
Copy link
Author

@kdk Thanks for your input. We followed the steps you mentioned. Please let us know if something else needs to be done. Thanks again.

@taalexander taalexander requested a review from kdk August 17, 2021 01:14
@javabster javabster linked an issue Sep 7, 2021 that may be closed by this pull request
dedicated directory for pulse transformations in the transpiler #6079
Closed
@javabster
Copy link
Contributor

Apologies for the slow response on this but it looks like the issue has already been taken care of in #6759 so this PR is no longer needed. Thanks for your efforts anyway @vkumar19, feel free to pick up another issue if you like 😄

@javabster javabster closed this Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanPuzzuoli DanPuzzuoli Awaiting requested review from DanPuzzuoli

@eggerdj eggerdj Awaiting requested review from eggerdj eggerdj is a code owner

@lcapelluto lcapelluto Awaiting requested review from lcapelluto

@nkanazawa1989 nkanazawa1989 Awaiting requested review from nkanazawa1989

@taalexander taalexander Awaiting requested review from taalexander

@kdk kdk Awaiting requested review from kdk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dedicated directory for pulse transformations in the transpiler
4 participants
@vkumar19 @javabster @kdk @amitracal