Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dedicated directory for pulse transformations in the transpiler #6079

Closed
ajavadia opened this issue Mar 24, 2021 · 6 comments
Closed

dedicated directory for pulse transformations in the transpiler #6079

ajavadia opened this issue Mar 24, 2021 · 6 comments
Assignees
Labels
good first issue Good for newcomers
Milestone

Comments

@ajavadia
Copy link
Member

In #5752 there is some code added to compile to pulses (by adding specific pulse calibrations for gates). These ended up in the scheduling folder but that's not a suitable place, as that folder is more about timing of gates via delays.
Pulse compilation is analogous to the defcals in openqasm3, so we should create a place for those and consolidate any other pulse transformations that are currently happening in Qiskit under there.

@ajavadia ajavadia added bug Something isn't working and removed bug Something isn't working labels Mar 24, 2021
@taalexander taalexander added the good first issue Good for newcomers label Mar 25, 2021
@amitracal
Copy link

Is this moving file from one folder to another ?

@javabster
Copy link
Contributor

Is this moving file from one folder to another ?

Hi @amitracal yes, qiskit/transpiler/passes/scheduling/calibration_creators.py and qiskit/transpiler/passes/scheduling/rzx_templates.py should be moved to a new folder specifically for pulse compilation. And if there is any similar pulse transformation code elsewhere in Qiskit that should also be moved into the new folder

@fs1132429
Copy link
Contributor

I am new and I would like to work on this issue if its ok.

@amitracal
Copy link

I am actually working on it, can you please choose another one ?

@fs1132429
Copy link
Contributor

ok

@javabster
Copy link
Contributor

Closing this issue as it was taken care of in #6759

@kdk kdk added this to the 0.19 milestone Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants