[Stable] Finish deprecation for line_length and fold in style dict #3200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR Qiskit#3018 deprecated the fold field in the style dict and the line_length kwarg for the circuit drawer. However, it was not documented in a release note as such. This commit corrects that oversight by adding a release note documenting the deprecation of both options. It also takes the opportunity to clear up some small nits from code review in the docstring for the new fold kwarg (which replaces both deprecated options).
mtreinish
requested review from
ajavadia,
ewinston,
jaygambetta,
kdk and
nonhermitian
as code owners
ajavadia
previously approved these changes
Oct 7, 2019
…3260) * Move barrier_before_final_measurements to passes/ directory * Edit import path of BarrierBeforeFinalMeasurements
Now that qiskit-terra 0.10.0 is out the door we should bump the version string on master to show the source version we're installing is newer than what's been released.
mtreinish
added
the
stable backport potential
mtreinish
changed the title
|
This missed 0.10 I will add the release notes manually to the docs in the meta bump. I will repush a new PR for just the docstring updates. |
|
Added to the release notes manually here: 3076fec |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
PR #3108 deprecated the fold field in the style dict and the line_length
kwarg for the circuit drawer. However, it was not documented in a
release note as such. This commit corrects that oversight by adding a
release note documenting the deprecation of both options. It also takes
the opportunity to clear up some small nits from code review in the
docstring for the new fold kwarg (which replaces both deprecated
options).
Details and comments