"fold" option unified across drawers #3108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 18 commits
September 14, 2019 15:07
This reverts commit bba055f.
1ucian0
requested review from
ajavadia,
ewinston,
jaygambetta,
kdk,
mtreinish and
nonhermitian
as code owners
5 tasks
added 2 commits
September 26, 2019 15:12
|
Since #3105 got merged, removing |
ajavadia
reviewed
Sep 29, 2019
ajavadia
previously approved these changes
Oct 4, 2019
ajavadia
approved these changes
Oct 4, 2019
mtreinish
approved these changes
Oct 4, 2019
| @@ -604,6 +604,12 @@ def draw(self, scale=0.7, filename=None, style=None, output=None, | |||
| idle_wires (bool): Include idle wires. Default is True. | |||
| with_layout (bool): Include layout information, with labels on the physical | |||
| layout. Default is True. | |||
| fold (int): Sets pagination. It can be disabled using -1. | |||
| In `text`, sets the length of the lines. This useful when the | |||
There was a problem hiding this comment.
Suggested change
| In `text`, sets the length of the lines. This useful when the | |
| In `text`, sets the length of the lines. This is useful when the |
| drawing does not fit in the console. If None (default), it will try to | ||
| guess the console width using `shutil.get_terminal_size()`. However, if | ||
| running in jupyter, the default line length is set to 80 characters. | ||
| In `mpl` is the amount of operations before folding. Default is 25. |
There was a problem hiding this comment.
It might be worth saying explicitly that for latex and latex_source this does nothing
| drawing does not fit in the console. If None (default), it will try to | ||
| guess the console width using `shutil.get_terminal_size()`. However, if | ||
| running in jupyter, the default line length is set to 80 characters. | ||
| In `mpl` is the amount of operations before folding. Default is 25. |
1ucian0
added
the
Changelog: API Change
This was referenced Oct 5, 2019
mergify bot
added a commit
that referenced
this pull request
Jun 18, 2020
* remove line_length * release note Co-authored-by: Julien Gacon <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
faisaldebouni
pushed a commit
to faisaldebouni/qiskit-terra
that referenced
this pull request
Aug 5, 2020
* test * cast in insinstance * style * layouts are already layouts :) * style['plotbarrier'] is being deprecated * internal param for text drawer renamed to plot_barriers * error when style contains unknown options * better error message * deprecated style option * mp karg fold * text fold * lint * docstring * cregbundle text option * Revert "cregbundle text option" This reverts commit bba055f. * revert 3100 * new pickles * cleaning up the diff * docstring * pickles
faisaldebouni
pushed a commit
to faisaldebouni/qiskit-terra
that referenced
this pull request
Aug 5, 2020
…skit#4507) * remove line_length * release note Co-authored-by: Julien Gacon <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes partially #2797
On top of PR #3105, so
on holduntil #3105 gets merged.Deprecates
line_lengthin favor afold.