Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable monitor tests #1533

Merged
merged 4 commits into from
Dec 18, 2018
Merged

Enable monitor tests #1533

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
82f43bd
Enable job monitor tests
diego-plan9 Dec 17, 2018
2a62aba
Merge branch 'master' into fix/backend-monitor-test
nonhermitian Dec 17, 2018
2074f18
Merge branch 'master' into fix/backend-monitor-test
jaygambetta Dec 17, 2018
0d0a897
Merge branch 'master' into fix/backend-monitor-test
diego-plan9 Dec 18, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions test/python/tools/jupyter/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
# -*- coding: utf-8 -*-

# Copyright 2018, IBM.
#
# This source code is licensed under the Apache License, Version 2.0 found in
# the LICENSE.txt file in the root directory of this source tree.

"""Tests for Jupyter-related functionality."""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems a bit absurd we need a docstring for an empty file? Also the copyright header doesn't really apply because there is no "source code" to license.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically it is not "a docstring for an empty file" - it is the docstring for the package.

But on a more practical tone, it's mostly about sticking to the current convention we have in place and being consistent - I'm personally happy to reevaluate it as a whole if needed, but seeing that it was mostly introduced at #550 and that it enters the legal territory, I'd err on the side of caution in these cases.

8 changes: 8 additions & 0 deletions test/python/tools/monitor/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
# -*- coding: utf-8 -*-

# Copyright 2018, IBM.
#
# This source code is licensed under the Apache License, Version 2.0 found in
# the LICENSE.txt file in the root directory of this source tree.

"""Tests for backend monitor-related functionality."""
3 changes: 2 additions & 1 deletion test/python/tools/monitor/test_backend_monitor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
# This source code is licensed under the Apache License, Version 2.0 found in
# the LICENSE.txt file in the root directory of this source tree.

# pylint: disable=redefined-builtin

"""Tests for the wrapper functionality."""

Expand All @@ -17,12 +16,14 @@

class TestBackendOverview(QiskitTestCase):
"""Tools test case."""

@requires_qe_access
def test_backend_overview(self, qe_token, qe_url):
"""Test backend_overview"""
IBMQ.enable_account(qe_token, qe_url)
backend_overview()

@requires_qe_access
def test_backend_monitor(self, qe_token, qe_url):
"""Test backend_monitor"""
IBMQ.enable_account(qe_token, qe_url)
Expand Down
2 changes: 0 additions & 2 deletions test/python/tools/monitor/test_job_monitor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,6 @@
# This source code is licensed under the Apache License, Version 2.0 found in
# the LICENSE.txt file in the root directory of this source tree.

# pylint: disable=redefined-builtin

"""Tests for the wrapper functionality."""

import unittest
Expand Down