Enable monitor tests #1533
Merged
Enable monitor tests #1533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diego-plan9
requested review from
1ucian0,
ajavadia,
atilag,
delapuente,
ewinston,
jaygambetta,
mtreinish,
nonhermitian and
taalexander
as code owners
mtreinish
approved these changes
Dec 17, 2018
| # This source code is licensed under the Apache License, Version 2.0 found in | ||
| # the LICENSE.txt file in the root directory of this source tree. | ||
|
|
||
| """Tests for Jupyter-related functionality.""" |
There was a problem hiding this comment.
This seems a bit absurd we need a docstring for an empty file? Also the copyright header doesn't really apply because there is no "source code" to license.
There was a problem hiding this comment.
Technically it is not "a docstring for an empty file" - it is the docstring for the package.
But on a more practical tone, it's mostly about sticking to the current convention we have in place and being consistent - I'm personally happy to reevaluate it as a whole if needed, but seeing that it was mostly introduced at #550 and that it enters the legal territory, I'd err on the side of caution in these cases.
lia-approves
pushed a commit
to edasgupta/qiskit-terra
that referenced
this pull request
Jul 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Following up on #1231: adds a
__init__.pytotest/python/tools/monitor/so the tests are actually executed by the CIs and tooling.Details and comments