deprecate legacy pulse builder command

[MozammilQ]

Summary

This addresses issue #11152

This PR

Deprecates

• qiskit.pulse.builder.call_gate

• qiskit.pulse.builder.cx

• qiskit.pulse.builder.u1

• qiskit.pulse.builder.u2

• qiskit.pulse.builder.u3

• qiskit.pulse.builder.x

• qiskit.pulse.builder.active_transpiler_settings

• qiskit.pulse.builder.active_circuit_scheduler_settings

• qiskit.pulse.builder.transpiler_settings

• arguments default_transpiler_settings ,
  and default_circuit_scheduler_settings of
  qiskit.pulse.builder.build function.

• QuantumCircuit type of the target argument in qiskit.pulse.builder.call function

Modifies:

• Module doc of qiskit.pulse.builder.py (example code with circuit elements)
• The example code 3 of function doc for qiskit.pulse.builder.call

and, modifies related tests in

• test/python/pulse/test_builder.py
• test/python/pulse/test_block.py
• test/python/pulse/test_builder_v2.py
• test/python/transpiler/test_calibrationbuilder.py

Details and comments

Refer to Issue: #11152
fixes #11152

[qiskit-bot]

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the the following people are requested to review this:

• @Qiskit/terra-core
• @nkanazawa1989

[MozammilQ]

@nkanazawa1989 , please see if this is good enough :)

[TsafrirA]

Thanks @MozammilQ for opening this PR.

I believe the deprecation message and the release notes should be clearer in conveying the alternative we want the users to use. While it is possible to extract the calibration from the Target and add it to the ScheduleBlock, the thing we want them to do is actually to move this logic into the circuit portion of their jobs. So, instead of having pulse.cx we want them to use circuit.cx outside of the pulse builder, as part of the circuit.

[nkanazawa1989]

Thanks Tsafrir. That's good point. I agree we should encourage users to write their program with QuantumCircuit model and call non-circuit part as a pulse gate. @MozammilQ could you please rephrase the waring message? Something like

Use QuantumCircuit with XGate instead, and attach the rest of pulse sequence as a pulse gate

should be okey.

[MozammilQ]

@nkanazawa1989 , please see if this is good enough :)

[TsafrirA]

This is much better. Still needs some more careful wording. Some of the docs haven't been adjusted, I will try to highlight them separately.

[TsafrirA]

The example here should be removed.

[MozammilQ]

@TsafrirA ,
Applied all suggestions :)
I have done exactly as you have suggested!
I am afraid, I would have ever considered going this verbose on deprecation messages which was a mistake that I will take care of next time :)

@nkanazawa1989

[nkanazawa1989]

Deprecation for circuit_scheduler_settings command is missing. Apart from this, the PR looks good to go.

[MozammilQ]

@nkanazawa1989 , please see if this is good enough :)

[nkanazawa1989]

Sorry I didn't carefully check the release note. Here is additional suggestions to make it better.

[MozammilQ]

@nkanazawa1989 , please see if this is good enough :)

[nkanazawa1989]

LGTM. Thanks @MozammilQ