-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate legacy pulse builder command. #11152
Comments
@nkanazawa1989 , should I go ahead with this? If I am allowed to? |
Thanks! I just assigned this to you. |
Note: An alternative of |
A PR for this seems to be very straight forward, just deprecated these functions, modify tests and add a release note, that's it! |
@nkanazawa1989 , I think this should be closed isn't it? |
Right, thanks for the reminder! |
What should we add?
Pulse builder still supports following commands that inject circuit gate operation into the pulse context:
qiskit.pulse.builder.call_gate
qiskit.pulse.builder.cx
qiskit.pulse.builder.u1
qiskit.pulse.builder.u2
qiskit.pulse.builder.u3
qiskit.pulse.builder.x
These are legacy workflow which we implemented before the pulse gate feature. These command introduce weird cyclic dependency between circuit and pulse program, and must be deprecated before the next release.
In addition, following commands are nice to be deprecated as well.
qiskit.pulse.builder.active_transpiler_settings
qiskit.pulse.builder.active_circuit_scheduler_settings
qiskit.pulse.builder.transpiler_settings
Background
Note that the standard program representation in Qiskit is now
QuantumCircuit
, and pulse programs exist as a microcode (calibration) of the circuit. The pulse builder is a tool to define such microprograms, and circuit -> pulse conversion must be explicitly done with the circuit scheduler. Injecting circuit instruction in pulse program is indeed an opposite workflow.The text was updated successfully, but these errors were encountered: