Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change cvxpy solver #11002

Merged
merged 2 commits into from
Oct 10, 2023
Merged

Change cvxpy solver #11002

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0ec33ed
change cvxpy solver
t-imamichi Oct 10, 2023
3d4cf38
apply review comments
t-imamichi Oct 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion qiskit/quantum_info/operators/measures.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -344,7 +344,7 @@ def cvx_bmat(mat_r, mat_i):
# Objective function
obj = cvxpy.Maximize(cvxpy.trace(choi_rt_r @ x_r) + cvxpy.trace(choi_rt_i @ x_i))
prob = cvxpy.Problem(obj, cons)
sol = prob.solve(**kwargs)
sol = prob.solve(solver="SCS", **kwargs)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this works, we should specify the solver as a direct kwarg in the diamond_norm function with a default of "SCS" so that users can continue to override it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I updated the code.

return sol


Expand Down
Loading