Change cvxpy solver #11002
Merged
Change cvxpy solver #11002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One or more of the the following people are requested to review this:
|
jakelishman
reviewed
Oct 10, 2023
| sol = prob.solve(**kwargs) | ||
| sol = prob.solve(solver="SCS", **kwargs) |
There was a problem hiding this comment.
If this works, we should specify the solver as a direct kwarg in the diamond_norm function with a default of "SCS" so that users can continue to override it.
There was a problem hiding this comment.
Thanks. I updated the code.
jakelishman
approved these changes
Oct 10, 2023
There was a problem hiding this comment.
Assuming this passes tests, this looks good to me, thanks for the fix! I hadn't actually spotted in the release notes that there'd been a change in the default solver away from SCS this version, but I just tried it locally and it all seems correct.
Thanks for solving the problem properly!
jakelishman
added
stable backport potential
mergify bot
pushed a commit
that referenced
this pull request
Oct 10, 2023
* change cvxpy solver * apply review comments (cherry picked from commit 4f5d90d)
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 10, 2023
* change cvxpy solver * apply review comments (cherry picked from commit 4f5d90d) Co-authored-by: Takashi Imamichi <[email protected]>
github-merge-queue bot
pushed a commit
to qiskit-community/qiskit-experiments
that referenced
this pull request
Oct 11, 2023
### Summary Similar to Qiskit/qiskit#11002, this PR fixes the default solver for cvxpy to SCS. The 1.4.0 release changing the default solver to Clarabel breaks tomography experiments because Clarabel expects `max_iter` instead of `max_iters`. Also fixes a new lint error in `test_drag.py`.
github-merge-queue bot
pushed a commit
to qiskit-community/qiskit-experiments
that referenced
this pull request
Oct 11, 2023
### Summary Similar to Qiskit/qiskit#11002, this PR fixes the default solver for cvxpy to SCS. The 1.4.0 release changing the default solver to Clarabel breaks tomography experiments because Clarabel expects `max_iter` instead of `max_iters`. Also fixes a new lint error in `test_drag.py`.
github-merge-queue bot
pushed a commit
to qiskit-community/qiskit-experiments
that referenced
this pull request
Oct 12, 2023
### Summary Similar to Qiskit/qiskit#11002, this PR fixes the default solver for cvxpy to SCS. The 1.4.0 release changing the default solver to Clarabel breaks tomography experiments because Clarabel expects `max_iter` instead of `max_iters`. Also fixes a new lint error in `test_drag.py` and reduces `test_ef_update`'s runtime.
github-merge-queue bot
pushed a commit
to qiskit-community/qiskit-experiments
that referenced
this pull request
Oct 12, 2023
### Summary Similar to Qiskit/qiskit#11002, this PR fixes the default solver for cvxpy to SCS. The 1.4.0 release changing the default solver to Clarabel breaks tomography experiments because Clarabel expects `max_iter` instead of `max_iters`. Also fixes a new lint error in `test_drag.py` and reduces `test_ef_update`'s runtime.
github-merge-queue bot
pushed a commit
to qiskit-community/qiskit-experiments
that referenced
this pull request
Oct 12, 2023
### Summary Similar to Qiskit/qiskit#11002, this PR fixes the default solver for cvxpy to SCS. The 1.4.0 release changing the default solver to Clarabel breaks tomography experiments because Clarabel expects `max_iter` instead of `max_iters`. Also fixes a new lint error in `test_drag.py` and reduces `test_ef_update`'s runtime.
|
Details of the solver change. cvxpy/cvxpy#2257 |
nkanazawa1989
pushed a commit
to nkanazawa1989/qiskit-experiments
that referenced
this pull request
Jan 10, 2024
### Summary Similar to Qiskit/qiskit#11002, this PR fixes the default solver for cvxpy to SCS. The 1.4.0 release changing the default solver to Clarabel breaks tomography experiments because Clarabel expects `max_iter` instead of `max_iters`. Also fixes a new lint error in `test_drag.py` and reduces `test_ef_update`'s runtime.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
CVXPY 1.4.0 has been released recently and it changed the default solver from SCS to CLARABEL.
https://www.cvxpy.org/updates/index.html#cvxpy-1-4
But the new solver took so long time to converge, and the following unit test fails.
test.python.quantum_info.operators.test_measures.TestOperatorMeasures.test_diamond_norm_3CI log example https://dev.azure.com/qiskit-ci/qiskit/_build/results?buildId=50270&view=logs&j=047b33e0-32e5-58f1-0c38-5f1e11815a2c&t=0892c657-33d9-5456-4eb8-9e7ebbe33ddf
This PR specifies the old solver to pass the unit test.
Details and comments