Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deprecate qiskit.test #11001

Merged
merged 4 commits into from
Jan 13, 2024
Merged

deprecate qiskit.test #11001

merged 4 commits into from
Jan 13, 2024

Conversation

1ucian0
Copy link
Member

@1ucian0 1ucian0 commented Oct 10, 2023 •
edited
Loading

Fixes #6862

@1ucian0 1ucian0 added this to the 0.46.0 milestone Oct 10, 2023
This was referenced Oct 10, 2023
Merged
Closed
Closed
Closed
Closed
@1ucian0 1ucian0 changed the base branch from main to stable/0.45 October 25, 2023 11:09
@1ucian0 1ucian0 changed the base branch from stable/0.45 to stable/0.46 November 3, 2023 20:41
@1ucian0 1ucian0 marked this pull request as ready for review November 5, 2023 20:39
@1ucian0 1ucian0 requested a review from a team as a code owner November 5, 2023 20:39
@qiskit-bot
Copy link
Collaborator

One or more of the the following people are requested to review this:

  • @Qiskit/terra-core

jakelishman
jakelishman reviewed Dec 20, 2023
View reviewed changes
Copy link
Member

@jakelishman jakelishman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could do with a release note containing a bit more explanation, but in principle we're all agreed on getting rid of qiskit.test as a public module.

@jakelishman jakelishman mentioned this pull request Dec 20, 2023
Merged
@1ucian0
Copy link
Member Author

1ucian0 commented Jan 12, 2024

Reno added in 0dc5da3. Maybe you want to have a look to the English quality, it's Fri 11:30pm here and the synapse is getting lazy.

@jakelishman jakelishman force-pushed the deprecate/qiskit.test branch from 1e82e9c to 3565b32 Compare January 12, 2024 23:48
jakelishman
jakelishman approved these changes Jan 12, 2024
View reviewed changes
Copy link
Member

@jakelishman jakelishman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha, I think that's just an indication that it's time to put down work for the evening.

@jakelishman jakelishman enabled auto-merge January 12, 2024 23:48
@jakelishman jakelishman added the Changelog: Deprecation Include in "Deprecated" section of changelog label Jan 12, 2024
@jakelishman jakelishman added this pull request to the merge queue Jan 13, 2024
Merged via the queue into Qiskit:stable/0.46 with commit 1a607ea Jan 13, 2024
12 checks passed
@1ucian0 1ucian0 deleted the deprecate/qiskit.test branch January 15, 2024 13:36
@jakelishman jakelishman mentioned this pull request Jan 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakelishman jakelishman jakelishman approved these changes

Assignees
No one assigned
Labels
Changelog: Deprecation Include in "Deprecated" section of changelog
Projects
None yet
Milestone
0.46.0
Development

Successfully merging this pull request may close these issues.

Deprecate qiskit.test
3 participants
@1ucian0 @qiskit-bot @jakelishman