Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove qiskit.test #10998

Merged
merged 24 commits into from
Jan 31, 2024
Merged

Remove qiskit.test #10998

merged 24 commits into from
Jan 31, 2024

Conversation

1ucian0
Copy link
Member

@1ucian0 1ucian0 commented Oct 10, 2023

Summary

Related to #6862

To be deprecated in 0.46 #11001

Details and comments

@coveralls
Copy link

coveralls commented Nov 5, 2023

Pull Request Test Coverage Report for Build 7726439144

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 31 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.02%) to 89.572%

Files with Coverage Reduction New Missed Lines %
qiskit/exceptions.py 2 93.75%
crates/qasm2/src/lex.rs 5 91.94%
crates/qasm2/src/parse.rs 24 96.23%
Totals Coverage Status
Change from base Build 7721773451: -0.02%
Covered Lines: 59308
Relevant Lines: 66213

💛 - Coveralls

@1ucian0 1ucian0 marked this pull request as ready for review November 27, 2023 09:58
@qiskit-bot
Copy link
Collaborator

One or more of the the following people are requested to review this:

  • @enavarro51
  • @Cryoris
  • @Qiskit/terra-core
  • @ajavadia
  • @ikkoham
  • @levbishop
  • @mtreinish
  • @nkanazawa1989
  • @t-imamichi

@mtreinish
Copy link
Member

Is the intent to remove all of qiskit/test or just qiskit/test/mock? The test changes and PR title make it sound like the former but the diff is only for the latter.

@mtreinish mtreinish modified the milestones: 1.0.0b1, 1.0.0 Dec 1, 2023
@jakelishman
Copy link
Member

I had forgotten this PR existed, but I've made #11445 which replaces quite a bit of this PR - it removes large tracts of qiskit.test without moving the remaining components, so we can split off the "remove dead code" and "rename qiskit.test" components of our aims with qiskit.test.

This PR already has lots of merge conflicts, whereas #11445 should be rather easier to merge in that regard - it doesn't try to do the removals and the touch-every-test-file bit in the same PR.

@1ucian0 1ucian0 requested a review from a team as a code owner January 31, 2024 12:14
Copy link
Member

@jakelishman jakelishman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got weirded out when the GitHub diff didn't appear to show the removal of the qiskit/test directory, but it turns out that it's tracked each file in there as a rename, and that's just how it shows things.

I'm going to move this to merge now - it appears to be done correctly to me (barring last-minute lint/whatever). I think we could expand the release note, but we'll do that post rc1 when we sort out the rest of them, and this PR needs to get in the merge queue ASAP to avoid further conflicts arising.

@jakelishman jakelishman enabled auto-merge January 31, 2024 13:07
@jakelishman jakelishman added this pull request to the merge queue Jan 31, 2024
Merged via the queue into Qiskit:main with commit e0b435e Jan 31, 2024
12 checks passed
@1ucian0 1ucian0 deleted the remove/qiskit.test branch January 31, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants