-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove qiskit.test
#10998
Remove qiskit.test
#10998
Conversation
Pull Request Test Coverage Report for Build 7726439144Warning: This coverage report may be inaccurate.We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
💛 - Coveralls |
One or more of the the following people are requested to review this:
|
Is the intent to remove all of |
I had forgotten this PR existed, but I've made #11445 which replaces quite a bit of this PR - it removes large tracts of This PR already has lots of merge conflicts, whereas #11445 should be rather easier to merge in that regard - it doesn't try to do the removals and the touch-every-test-file bit in the same PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I got weirded out when the GitHub diff didn't appear to show the removal of the qiskit/test
directory, but it turns out that it's tracked each file in there as a rename, and that's just how it shows things.
I'm going to move this to merge now - it appears to be done correctly to me (barring last-minute lint/whatever). I think we could expand the release note, but we'll do that post rc1 when we sort out the rest of them, and this PR needs to get in the merge queue ASAP to avoid further conflicts arising.
Summary
Related to #6862
To be deprecated in 0.46 #11001
Details and comments